Skip to content

Commit

Permalink
Issue #3160031 by quietone, alexpott, jungle, longwave, jameszhang023…
Browse files Browse the repository at this point in the history
…: Fix 18 spelling errors for migrate specific terms
  • Loading branch information
alexpott committed Aug 3, 2020
1 parent 9cb8078 commit 6016c7d
Show file tree
Hide file tree
Showing 24 changed files with 79 additions and 79 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ protected function setUp() {
* @covers ::transform
*/
public function testTransformNoData() {
$transformed_value = $this->plugin->transform([0, '', []], $this->migrateExecutable, $this->row, 'destinationproperty');
$transformed_value = $this->plugin->transform([0, '', []], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertEmpty($transformed_value);
}

/**
* @covers ::transform
*/
public function testTransformSinglePageWithFront() {
$visibility = $this->plugin->transform([0, '<front>', []], $this->migrateExecutable, $this->row, 'destinationproperty');
$visibility = $this->plugin->transform([0, '<front>', []], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('request_path', $visibility['request_path']['id']);
$this->assertTrue($visibility['request_path']['negate']);
$this->assertSame('<front>', $visibility['request_path']['pages']);
Expand All @@ -55,7 +55,7 @@ public function testTransformSinglePageWithFront() {
* @covers ::transform
*/
public function testTransformMultiplePagesWithFront() {
$visibility = $this->plugin->transform([1, "foo\n/bar\rbaz\r\n<front>", []], $this->migrateExecutable, $this->row, 'destinationproperty');
$visibility = $this->plugin->transform([1, "foo\n/bar\rbaz\r\n<front>", []], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('request_path', $visibility['request_path']['id']);
$this->assertFalse($visibility['request_path']['negate']);
$this->assertSame("/foo\n/bar\n/baz\n<front>", $visibility['request_path']['pages']);
Expand All @@ -66,7 +66,7 @@ public function testTransformMultiplePagesWithFront() {
*/
public function testTransformPhpEnabled() {
$this->moduleHandler->moduleExists('php')->willReturn(TRUE);
$visibility = $this->plugin->transform([2, '<?php', []], $this->migrateExecutable, $this->row, 'destinationproperty');
$visibility = $this->plugin->transform([2, '<?php', []], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('php', $visibility['php']['id']);
$this->assertFalse($visibility['php']['negate']);
$this->assertSame('<?php', $visibility['php']['php']);
Expand All @@ -77,7 +77,7 @@ public function testTransformPhpEnabled() {
*/
public function testTransformPhpDisabled() {
$this->moduleHandler->moduleExists('php')->willReturn(FALSE);
$transformed_value = $this->plugin->transform([2, '<?php', []], $this->migrateExecutable, $this->row, 'destinationproperty');
$transformed_value = $this->plugin->transform([2, '<?php', []], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertEmpty($transformed_value);
}

Expand All @@ -97,7 +97,7 @@ public function testTransformException() {
$this->plugin = new BlockVisibility(['skip_php' => TRUE], 'block_visibility_pages', [], $this->moduleHandler->reveal(), $migrate_lookup->reveal());
$this->expectException(MigrateSkipRowException::class);
$this->expectExceptionMessage("The block with bid '99' from module 'foobar' will have no PHP or request_path visibility configuration.");
$this->plugin->transform([2, '<?php', []], $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform([2, '<?php', []], $this->migrateExecutable, $this->row, 'destination_property');
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function testTransformAltTitle() {

$options = [
'alt' => 'Foobaz',
'title' => 'Wambooli',
'title' => 'Bar',
];
$value = [
'fid' => 1,
Expand All @@ -45,7 +45,7 @@ public function testTransformAltTitle() {
'display' => TRUE,
'description' => '',
'alt' => 'Foobaz',
'title' => 'Wambooli',
'title' => 'Bar',
];
$this->assertSame($expected, $transformed);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function testTransform() {
'es' => 'es.example.com',
'hu' => 'hu.example.com',
];
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($value, $expected);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function testTransformWithWeights() {
'language-selected' => -6,
],
];
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($value, $expected);
}

Expand All @@ -70,7 +70,7 @@ public function testTransformWithoutWeights() {
'language-url-fallback' => 1,
],
];
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($value, $expected);
}

Expand All @@ -81,7 +81,7 @@ public function testStringInput() {
$this->plugin = new LanguageNegotiation([], 'map', []);
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('The input should be an array');
$this->plugin->transform('foo', $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform('foo', $this->migrateExecutable, $this->row, 'destination_property');
}

}
6 changes: 3 additions & 3 deletions modules/language/tests/src/Unit/process/LanguageTypesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function testTransformAll() {
1 => 'language_content',
2 => 'language_interface',
];
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($value, $expected);
}

Expand All @@ -44,7 +44,7 @@ public function testTransformConfigurable() {
$expected = [
0 => 'language_interface',
];
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($value, $expected);
}

Expand All @@ -55,7 +55,7 @@ public function testStringInput() {
$this->plugin = new LanguageTypes([], 'map', []);
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('The input should be an array');
$this->plugin->transform('foo', $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform('foo', $this->migrateExecutable, $this->row, 'destination_property');
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public function doTransform($value, $configuration = []) {
$executable = $this->prophesize(MigrateExecutableInterface::class)->reveal();

$plugin = new LinkUri($configuration, 'link_uri', [], $entityTypeManager, $routeBuilder);
$actual = $plugin->transform($value, $executable, $row, 'destinationproperty');
$actual = $plugin->transform($value, $executable, $row, 'destination_property');

return $actual;
}
Expand Down
8 changes: 4 additions & 4 deletions modules/migrate/src/Plugin/migrate/process/Concat.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
* @endcode
*
* This will set new_text_field to the concatenation of the 'foo' and 'bar'
* source values. For example, if the 'foo' property is "wambooli" and the 'bar'
* property is "pastafazoul", new_text_field will be "wamboolipastafazoul".
* source values. For example, if the 'foo' property is "Rosa" and the 'bar'
* property is "Parks", new_text_field will be "RosaParks".
*
* You can also specify a delimiter.
*
Expand All @@ -46,8 +46,8 @@
*
* This will set new_text_field to the concatenation of the 'foo' source value,
* the delimiter and the 'bar' source value. For example, using the values above
* and "/" as the delimiter, if the 'foo' property is "wambooli" and the 'bar'
* property is "pastafazoul", new_text_field will be "wambooli/pastafazoul".
* and "/" as the delimiter, if the 'foo' property is "Rosa" and the 'bar'
* property is "Rosa", new_text_field will be "Rosa/Parks".
*
* @see \Drupal\migrate\Plugin\MigrateProcessInterface
*
Expand Down
2 changes: 1 addition & 1 deletion modules/migrate/tests/src/Kernel/process/RouteTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ protected function doTransform($value) {
$executable = $this->prophesize(MigrateExecutableInterface::class)->reveal();

$plugin = new Route([], 'route', [], $migration, $pathValidator);
$actual = $plugin->transform($value, $executable, $row, 'destinationproperty');
$actual = $plugin->transform($value, $executable, $row, 'destination_property');
return $actual;
}

Expand Down
10 changes: 5 additions & 5 deletions modules/migrate/tests/src/Unit/process/ArrayBuildTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function testTransform() {
'Foo' => 'Bar',
'foo bar' => 'bar foo',
];
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($value, $expected);
}

Expand All @@ -48,7 +48,7 @@ public function testNonExistentKey() {
];
$this->expectException(MigrateException::class);
$this->expectExceptionMessage("The key 'foo' does not exist");
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
}

/**
Expand All @@ -60,7 +60,7 @@ public function testNonExistentValue() {
];
$this->expectException(MigrateException::class);
$this->expectExceptionMessage("The key 'bar' does not exist");
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
}

/**
Expand All @@ -70,7 +70,7 @@ public function testOneDimensionalArrayInput() {
$source = ['foo' => 'bar'];
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('The input should be an array of arrays');
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
}

/**
Expand All @@ -80,7 +80,7 @@ public function testStringInput() {
$source = 'foo';
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('The input should be an array of arrays');
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform($source, $this->migrateExecutable, $this->row, 'destination_property');
}

}
2 changes: 1 addition & 1 deletion modules/migrate/tests/src/Unit/process/CallbackTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CallbackTest extends MigrateProcessTestCase {
public function testCallback($callable) {
$configuration = ['callable' => $callable];
$this->plugin = new Callback($configuration, 'map', []);
$value = $this->plugin->transform('FooBar', $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform('FooBar', $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('foobar', $value);
}

Expand Down
6 changes: 3 additions & 3 deletions modules/migrate/tests/src/Unit/process/ConcatTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ protected function setUp() {
* Test concat works without a delimiter.
*/
public function testConcatWithoutDelimiter() {
$value = $this->plugin->transform(['foo', 'bar'], $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform(['foo', 'bar'], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('foobar', $value);
}

Expand All @@ -38,15 +38,15 @@ public function testConcatWithoutDelimiter() {
*/
public function testConcatWithNonArray() {
$this->expectException(MigrateException::class);
$this->plugin->transform('foo', $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform('foo', $this->migrateExecutable, $this->row, 'destination_property');
}

/**
* Test concat works without a delimiter.
*/
public function testConcatWithDelimiter() {
$this->plugin->setDelimiter('_');
$value = $this->plugin->transform(['foo', 'bar'], $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform(['foo', 'bar'], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('foo_bar', $value);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class DefaultValueTest extends MigrateProcessTestCase {
*/
public function testDefaultValue($configuration, $expected_value, $value) {
$process = new DefaultValue($configuration, 'default_value', []);
$value = $process->transform($value, $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $process->transform($value, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($expected_value, $value);
}

Expand Down
18 changes: 9 additions & 9 deletions modules/migrate/tests/src/Unit/process/ExplodeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ protected function setUp() {
* Test explode transform process works.
*/
public function testTransform() {
$value = $this->plugin->transform('foo,bar,tik', $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform('foo,bar,tik', $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame(['foo', 'bar', 'tik'], $value);
}

Expand All @@ -37,18 +37,18 @@ public function testTransform() {
*/
public function testTransformLimit() {
$plugin = new Explode(['delimiter' => '_', 'limit' => 2], 'map', []);
$value = $plugin->transform('foo_bar_tik', $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $plugin->transform('foo_bar_tik', $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame(['foo', 'bar_tik'], $value);
}

/**
* Test if the explode process can be chained with a handles_multiple process.
*/
public function testChainedTransform() {
$exploded = $this->plugin->transform('foo,bar,tik', $this->migrateExecutable, $this->row, 'destinationproperty');
$exploded = $this->plugin->transform('foo,bar,tik', $this->migrateExecutable, $this->row, 'destination_property');

$concat = new Concat([], 'map', []);
$concatenated = $concat->transform($exploded, $this->migrateExecutable, $this->row, 'destinationproperty');
$concatenated = $concat->transform($exploded, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('foobartik', $concatenated);
}

Expand All @@ -58,7 +58,7 @@ public function testChainedTransform() {
public function testExplodeWithNonString() {
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('is not a string');
$this->plugin->transform(['foo'], $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform(['foo'], $this->migrateExecutable, $this->row, 'destination_property');
}

/**
Expand All @@ -69,7 +69,7 @@ public function testExplodeWithNonString() {
public function testExplodeWithNonStrictAndEmptySource($value, $expected) {
$plugin = new Explode(['delimiter' => '|', 'strict' => FALSE], 'map', []);

$processed = $plugin->transform($value, $this->migrateExecutable, $this->row, 'destinationproperty');
$processed = $plugin->transform($value, $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame($expected, $processed);
}

Expand All @@ -96,7 +96,7 @@ public function testExplodeWithNonStrictAndNonCastable() {
$plugin = new Explode(['delimiter' => '|', 'strict' => FALSE], 'map', []);
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('cannot be casted to a string');
$processed = $plugin->transform(['foo'], $this->migrateExecutable, $this->row, 'destinationproperty');
$processed = $plugin->transform(['foo'], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame(['foo'], $processed);
}

Expand All @@ -106,7 +106,7 @@ public function testExplodeWithNonStrictAndNonCastable() {
*/
public function testExplodeWithStrictAndEmptyString() {
$plugin = new Explode(['delimiter' => '|'], 'map', []);
$processed = $plugin->transform('', $this->migrateExecutable, $this->row, 'destinationproperty');
$processed = $plugin->transform('', $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame([''], $processed);
}

Expand All @@ -117,7 +117,7 @@ public function testExplodeWithEmptyDelimiter() {
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('delimiter is empty');
$plugin = new Explode(['delimiter' => ''], 'map', []);
$plugin->transform('foo,bar', $this->migrateExecutable, $this->row, 'destinationproperty');
$plugin->transform('foo,bar', $this->migrateExecutable, $this->row, 'destination_property');
}

}
8 changes: 4 additions & 4 deletions modules/migrate/tests/src/Unit/process/ExtractTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ protected function setUp() {
* Tests successful extraction.
*/
public function testExtract() {
$value = $this->plugin->transform(['foo' => 'bar'], $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $this->plugin->transform(['foo' => 'bar'], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('bar', $value);
}

Expand All @@ -34,7 +34,7 @@ public function testExtract() {
public function testExtractFromString() {
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('Input should be an array.');
$this->plugin->transform('bar', $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform('bar', $this->migrateExecutable, $this->row, 'destination_property');
}

/**
Expand All @@ -43,15 +43,15 @@ public function testExtractFromString() {
public function testExtractFail() {
$this->expectException(MigrateException::class);
$this->expectExceptionMessage('Array index missing, extraction failed.');
$this->plugin->transform(['bar' => 'foo'], $this->migrateExecutable, $this->row, 'destinationproperty');
$this->plugin->transform(['bar' => 'foo'], $this->migrateExecutable, $this->row, 'destination_property');
}

/**
* Tests unsuccessful extraction.
*/
public function testExtractFailDefault() {
$plugin = new Extract(['index' => ['foo'], 'default' => 'test'], 'map', []);
$value = $plugin->transform(['bar' => 'foo'], $this->migrateExecutable, $this->row, 'destinationproperty');
$value = $plugin->transform(['bar' => 'foo'], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame('test', $value, '');
}

Expand Down
2 changes: 1 addition & 1 deletion modules/migrate/tests/src/Unit/process/FlattenTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class FlattenTest extends MigrateProcessTestCase {
*/
public function testFlatten() {
$plugin = new Flatten([], 'flatten', []);
$flattened = $plugin->transform([1, 2, [3, 4, [5]], [], [7, 8]], $this->migrateExecutable, $this->row, 'destinationproperty');
$flattened = $plugin->transform([1, 2, [3, 4, [5]], [], [7, 8]], $this->migrateExecutable, $this->row, 'destination_property');
$this->assertSame([1, 2, 3, 4, 5, 7, 8], $flattened);
}

Expand Down

0 comments on commit 6016c7d

Please sign in to comment.