Issue #3133604 by Berdir, dww: Dependency compatibility check in syst…

…em doesn't check if version is defined (cherry picked from commit 4da7958d271ada8bd6055b6a3e03b347afb6abe4)
drupal · May 10, 2020 · 9742587 · 9742587
1 parent 5bea0e2
commit 9742587
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/Drupal/Core/Extension/ThemeExtensionList.php b/lib/Drupal/Core/Extension/ThemeExtensionList.php
@@ -47,6 +47,7 @@ class ThemeExtensionList extends ExtensionList {
       'comment_user_verification',
     ],
     'screenshot' => 'screenshot.png',
+    'version' => NULL,
     'php' => DRUPAL_MINIMUM_PHP,
     'libraries' => [],
     'libraries_extend' => [],

diff --git a/tests/Drupal/KernelTests/Core/Extension/ThemeExtensionListTest.php b/tests/Drupal/KernelTests/Core/Extension/ThemeExtensionListTest.php
@@ -35,4 +35,12 @@ public function testGetlist() {
     $this->assertArrayHasKey('test_theme', $extensions);
   }
 
+  /**
+   * Tests that themes have an empty default version set.
+   */
+  public function testThemeWithoutVersion() {
+    $theme = \Drupal::service('extension.list.theme')->get('test_theme_settings_features');
+    $this->assertNull($theme->info['version']);
+  }
+
 }