Issue #3120910 by catch, tedbow, longwave, Pascal-, alexpott, Punyasl…

…oka: Sites with missing schema information can't update to 8.8.3+ - attempts to run all historical updates

includes/schema.inc

@@ -83,10 +83,9 @@ function drupal_get_installed_schema_version($module, $reset = FALSE, $array = F
   }
 
   if (!$versions) {
-    $versions = \Drupal::keyValue('system.schema')->getAll();
-    $enabled_modules = \Drupal::moduleHandler()->getModuleList();
-    $enabled_modules = array_fill_keys(array_keys($enabled_modules), \Drupal::CORE_MINIMUM_SCHEMA_VERSION);
-    $versions = array_merge($enabled_modules, $versions);
+    if (!$versions = \Drupal::keyValue('system.schema')->getAll()) {
+      $versions = [];
+    }
   }
 
   if ($array) {

includes/update.inc

@@ -103,12 +103,69 @@ function update_system_schema_requirements() {
  * Checks update requirements and reports errors and (optionally) warnings.
  */
 function update_check_requirements() {
+  // Because this is one of the earliest points in the update process,
+  // detect and fix missing schema versions for modules here to ensure
+  // it runs on all update code paths.
+  _update_fix_missing_schema();
+
   // Check requirements of all loaded modules.
   $requirements = \Drupal::moduleHandler()->invokeAll('requirements', ['update']);
   $requirements += update_system_schema_requirements();
   return $requirements;
 }
 
+/**
+ * Helper to detect and fix 'missing' schema information.
+ *
+ * Repairs the case where a module has no schema version recorded.
+ * This has to be done prior to updates being run, otherwise the update
+ * system would detect and attempt to run all historical updates for a
+ * module.
+ *
+ * @todo: remove in a major version after
+ * https://www.drupal.org/project/drupal/issues/3130037 has been fixed.
+ */
+function _update_fix_missing_schema() {
+  $versions = \Drupal::keyValue('system.schema')->getAll();
+  $module_handler = \Drupal::moduleHandler();
+  $enabled_modules = $module_handler->getModuleList();
+
+  foreach (array_keys($enabled_modules) as $module) {
+    // All modules should have a recorded schema version, but when they
+    // don't, detect and fix the problem.
+    if (!isset($versions[$module])) {
+      // Ensure the .install file is loaded.
+      module_load_install($module);
+      $all_updates = drupal_get_schema_versions($module);
+      // If the schema version of a module hasn't been recorded, we cannot
+      // know the actual schema version a module is at, because
+      // no updates will ever have been run on the site and it was not set
+      // correctly when the module was installed, so instead set it to
+      // the same as the last update. This means that updates will proceed
+      // again the next time the module is updated and a new update is
+      // added. Updates added in between the module being installed and the
+      // schema version being fixed here (if any have been added) will never
+      // be run, but we have no way to identify which updates these are.
+      if ($all_updates) {
+        $last_update = max($all_updates);
+      }
+      else {
+        $last_update = \Drupal::CORE_MINIMUM_SCHEMA_VERSION;
+      }
+      // If the module implements hook_update_last_removed() use the
+      // value of that if it's higher than the schema versions found so
+      // far.
+      if ($last_removed = $module_handler->invoke($module, 'update_last_removed')) {
+        $last_update = max($last_update, $last_removed);
+      }
+      drupal_set_installed_schema_version($module, $last_update);
+      $args = ['%module' => $module, '%last_update_hook' => $module . '_update_' . $last_update . '()'];
+      \Drupal::messenger()->addWarning(t('Schema information for module %module was missing from the database. You should manually review the module updates and your database to check if any updates have been skipped up to, and including, %last_update_hook.', $args));
+      \Drupal::logger('update')->warning('Schema information for module %module was missing from the database. You should manually review the module updates and your database to check if any updates have been skipped up to, and including, %last_update_hook.', $args);
+    }
+  }
+}
+
 /**
  * Forces a module to a given schema version.
  *
@@ -606,7 +663,7 @@ function update_retrieve_dependencies() {
   $return = [];
   // Get a list of installed modules, arranged so that we invoke their hooks in
   // the same order that \Drupal::moduleHandler()->invokeAll() does.
-  foreach (drupal_get_installed_schema_version(NULL, FALSE, TRUE) as $module => $schema) {
+  foreach (\Drupal::keyValue('system.schema')->getAll() as $module => $schema) {
     if ($schema == SCHEMA_UNINSTALLED) {
       // Nothing to upgrade.
       continue;

modules/system/tests/src/Functional/UpdateSystem/NoPreExistingSchemaUpdateTest.php

@@ -3,8 +3,9 @@
 namespace Drupal\Tests\system\Functional\UpdateSystem;
 
 use Drupal\Core\Database\Database;
+use Drupal\Core\Url;
 use Drupal\Tests\BrowserTestBase;
-use Drupal\Tests\UpdatePathTestTrait;
+use Drupal\Tests\RequirementsPageTrait;
 
 /**
  * Tries to update a module which has no pre-existing schema.
@@ -13,7 +14,7 @@
  * @group legacy
  */
 class NoPreExistingSchemaUpdateTest extends BrowserTestBase {
-  use UpdatePathTestTrait;
+  use RequirementsPageTrait;
 
   protected function setUp() {
     parent::setUp();
@@ -44,12 +45,28 @@ public function testNoPreExistingSchema() {
     $this->assertArrayNotHasKey('update_test_no_preexisting', $schema);
     $this->assertFalse(\Drupal::state()->get('update_test_no_preexisting_update_8001', FALSE));
 
-    $this->runUpdates();
+    $update_url = Url::fromRoute('system.db_update');
+    require_once $this->root . '/core/includes/update.inc';
+    // The site might be broken at the time so logging in using the UI might
+    // not work, so we use the API itself.
+    $this->writeSettings([
+      'settings' => [
+        'update_free_access' => (object) [
+          'value' => TRUE,
+          'required' => TRUE,
+        ],
+      ],
+    ]);
+
+    $this->drupalGet($update_url);
+    $this->updateRequirementsProblem();
 
     $schema = \Drupal::keyValue('system.schema')->getAll();
     $this->assertArrayHasKey('update_test_no_preexisting', $schema);
     $this->assertEquals('8001', $schema['update_test_no_preexisting']);
-    $this->assertTrue(\Drupal::state()->get('update_test_no_preexisting_update_8001', FALSE));
+    // The schema version has been fixed, but the update was never run.
+    $this->assertFalse(\Drupal::state()->get('update_test_no_preexisting_update_8001', FALSE));
+    $this->assertSession()->pageTextContains('Schema information for module update_test_no_preexisting was missing from the database. You should manually review the module updates and your database to check if any updates have been skipped up to, and including, update_test_no_preexisting_update_8001().');
   }
 
 }