Issue #3161199 by lauriii, bnjmnm: Remove $no_operator = TRUE from Vi…

…ews BooleanOperator (cherry picked from commit 761dbfb385a92dc163f9eff3bef9006d4f5e927a)
drupal · Jul 31, 2020 · fb90bbd · fb90bbd
1 parent acf2177
commit fb90bbd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/modules/views/src/Plugin/views/filter/BooleanOperator.php b/modules/views/src/Plugin/views/filter/BooleanOperator.php
@@ -43,8 +43,6 @@ class BooleanOperator extends FilterPluginBase {
 
   // exposed filter options
   protected $alwaysMultiple = TRUE;
-  // Don't display empty space where the operator would be.
-  public $no_operator = TRUE;
   // Whether to accept NULL as a false value or not
   public $accept_null = FALSE;
 

diff --git a/modules/views_ui/tests/src/Functional/FilterBooleanWebTest.php b/modules/views_ui/tests/src/Functional/FilterBooleanWebTest.php
@@ -32,6 +32,11 @@ public function testFilterBooleanUI() {
     $result = $this->cssSelect('#edit-options-value--wrapper legend span');
     $this->assertEqual($result[0]->getHtml(), 'Status');
 
+    // Ensure that the operator and the filter value are displayed using correct
+    // layout.
+    $this->assertSession()->elementExists('css', '.views-left-30 .form-item-options-operator');
+    $this->assertSession()->elementExists('css', '.views-right-70 .form-item-options-value');
+
     $this->drupalPostForm(NULL, [], t('Expose filter'));
     $this->drupalPostForm(NULL, [], t('Grouped filters'));