Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-down menu caret placement #133

Closed
jpstrikesback opened this issue Aug 7, 2014 · 3 comments
Closed

Drop-down menu caret placement #133

jpstrikesback opened this issue Aug 7, 2014 · 3 comments

Comments

@jpstrikesback
Copy link
Contributor

See: https://www.drupal.org/node/2262301 and http://getbootstrap.com/javascript/#dropdowns-examples

The dropdown caret is placed in it's own <a> and should probably be inside the dropdown <a>.

@jpstrikesback
Copy link
Contributor Author

PR is in #134

@jpstrikesback jpstrikesback reopened this Aug 7, 2014
@pmackay
Copy link

pmackay commented Aug 29, 2014

This could have the effect that its not possible to click on an actual main menu item. The Drupal Bootstrap theme I think already does what this issue suggests, but it means the visible menu item is just a toggle for showing the dropdown menu (maybe there is something I'm missing). Kalatheme current behaviour allows the visible menu item to be clicked and also click the caret to see the dropdown.

@katypool-zz
Copy link

Think we can close this out as #134 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants