Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drush.info (Remove sebastian/version in favor of composer-show --format=json) #2771

Open
weitzman opened this issue May 22, 2017 · 3 comments
Labels

Comments

@weitzman
Copy link
Member

weitzman commented May 22, 2017

if we get rid of drush.info, sebastian/version can't get the version number since Drush has been installed via Composer. composer-show can.

So this isssue would make composer a required program which seems not good for production sites.

@weitzman
Copy link
Member Author

weitzman commented Jun 1, 2017

Will be easier after #2788.

@weitzman
Copy link
Member Author

That PR merged, but it isn't quite enough. Right now composerRoot/drupalRoot is only discovered during bootstrap phase 1. We need it very early during preflight.

@weitzman
Copy link
Member Author

Actually, DrupalFinder is designed such that it doesn't find composerRoot unless it also finds drupalRoot. So this change would be problematic for the global Drush9 use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant