sql-dump adds fail text to SQL

[iainhouston]

The string "Connection to ...." (see below) is added to the SQL output; it will fail the subsequent importing of the SQL.
(drush 9.0.0-rc2)

$ drush @balive sql-dump > tmp.sql
tail tmp.sql
/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;
/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;
/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;
/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;

-- Dump completed on 2018-01-13  7:24:53
Connection to bradford-abbas.uk closed.

[iainhouston]

FYI Using Drush launcher 0.5.0; Drush 9.0.0-rc2 via composer.

[weitzman]

Looks like thats coming from ssh. See https://superuser.com/questions/457316/how-to-remove-connection-to-xx-xxx-xx-xxx-closed-message.

Can you run with --verbose so we can see the exact ssh command thats Drush is running?

[iainhouston]

Yes, it's using the -t flag.

$ drush @balive sql-dump > tmp.sql --verbose
Calling proc_open(ssh -o PasswordAuthentication=no -i ~/.ssh/BAPC-2.pem -t webmaster@bradford-abbas.uk 'drush  --verbose --root=/var/www/drupal/web --uri=bradford-abbas.uk  sql-dump --verbose 2>&1' 2>&1)

[weitzman]

I think this is a dupe of #1270.