Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential changes as it will soon be possible for themes to declare dependencies on modules. #4248

Open
bbenjamin opened this issue Nov 6, 2019 · 1 comment

Comments

@bbenjamin
Copy link

bbenjamin commented Nov 6, 2019

After roughly a decade, this issue has been escalated to critical and may actually see completion in the near future.
https://www.drupal.org/project/drupal/issues/474684

In my most recent patch at the time of writing this (#206), I made some changes to \Drupal\Core\Extension\ModuleHandler::buildModuleDependencies that prevent uninstalling modules that enabled themes depend on. The experience is not great at the moment - Drush will output an error rather than useful information about the dependencies.

It seems like changes might be needed on Drush's end to provide useful output when a user attempts to disable a module depended-upon by an enabled theme. I'd like to make sure I implement this in a way that ensures it works well with Drush. Please weigh in on that issue if there's anything you'd like considered in that feature's implementation.

@weitzman
Copy link
Member

weitzman commented Apr 7, 2020

This got in! A backward compatible Drush PR is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants