Fix CJS build for TypeScript #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7d4620 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
djMax
approved these changes
Sep 30, 2023
drwpow
approved these changes
Sep 30, 2023
Merged
diegohaz
pushed a commit
to ariakit/ariakit
that referenced
this pull request
Oct 13, 2023
…ort (#2935) Closes #2356 Taking this PR from another project as inspiration: openapi-ts/openapi-typescript#1360 This should fix ariakit-react typing in Typescript projects using NodeNext module/moduleresolution by explicitly pointing at a "cts" type definition file. It should not bother existing use cases but I left index.d.ts in the cjs module just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Should fix #1346
cjssubdirectory and copy the type declaration file asindex.d.ctsfrom the dist folderHow to Review
This changes only the build output for CJS projects. I created a small repo in https://github.com/marcomuser/cjsts where the mentioned bug report is reproducible. It is fixed when I update the dist folder in node_modules with the built openapi-fetch from this branch.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)