Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size change hotkeys not working #125

Open
ajkessel opened this issue Mar 26, 2014 · 5 comments
Open

Font size change hotkeys not working #125

ajkessel opened this issue Mar 26, 2014 · 5 comments

Comments

@ajkessel
Copy link

Pulled extension today (9ef52dc) and + and - aren't doing anything--can't change the size of the displayed text.

@ds300
Copy link
Owner

ds300 commented Mar 26, 2014

fixed in 5601442

Thanks for pointing it out :)

@ds300 ds300 closed this as completed Mar 26, 2014
@ajkessel
Copy link
Author

Just tried latest build--"-" (smaller) works, but not "+" (bigger).

@ds300
Copy link
Owner

ds300 commented Mar 27, 2014

Can anyone else confirm this? Works for me.

@ds300 ds300 reopened this Mar 27, 2014
@ajkessel
Copy link
Author

Maybe the issue here is just the the max size is too small. If I first shrink the box with "-" I can grow with "+", but only to a certain size (which was my starting size). On my laptop screen, the max size there is fine, but on my 30" LCD it is too small. Is there supposed to be a max size? If so, can it be increased for larger high resolution screens?

@ajkessel
Copy link
Author

ajkessel commented Apr 3, 2014

Confirmed that it is just the max size is too small on big monitors. This clamp line in helpers.js is limiting it:

  config.adjustScale = function (diff) {
    this("scale", H.clamp(0, options.scale + diff, 1));
  };

Changing "1" to "2" allows me to resize on a big screen, but then the letters aren't sharp. Presumably the better solution here is allowing the default font point size to be configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants