Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this working with lerna #88

Closed
belgac opened this issue Oct 11, 2018 · 3 comments
Closed

Is this working with lerna #88

belgac opened this issue Oct 11, 2018 · 3 comments

Comments

@belgac
Copy link

belgac commented Oct 11, 2018

Hi,

first of all thank you for this amazing package.

I'm currently migrating one of my repos to lerna, patch-package works great for applying patches in this environment. But to create a patch, the yarn installation seems to fail because it can't find the lerna.json file. Is there an already established way to fix this?

Thanks a lot!

@ds300 ds300 added this to To do in 6.0.0 release via automation Jan 13, 2019
@ds300 ds300 added this to Backlog in 7.0.0 Release Jan 13, 2019
@ds300 ds300 removed this from To do in 6.0.0 release Jan 13, 2019
@ds300
Copy link
Owner

ds300 commented Jan 27, 2019

Hi! 👋 Sorry, I haven't been able to figure out a sensible way to make patch-package work with yarn workspaces or lerna yet. It's the next major thing I want to focus on for patch package though, so stay tuned.

@ds300
Copy link
Owner

ds300 commented Apr 10, 2019

patch-package now works with yarn workspaces. I'm guessing everybody who uses lerna also uses yarn workspaces now? So I'll close this. Feel free to open a new issue specifically for lerna if there is something left to do.

See also #42

@ds300 ds300 closed this as completed Apr 10, 2019
@euanmillar
Copy link

Nice one @ds300 ! I'm about to use this amazing tool again. Hope you're well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants