Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note on allowSyntheticDefaultImports #47

Open
henrikra opened this issue Feb 20, 2018 · 8 comments
Open

Note on allowSyntheticDefaultImports #47

henrikra opened this issue Feb 20, 2018 · 8 comments

Comments

@henrikra
Copy link

In readme it reads:

This is neccessary until TypeScript implements suport for synthetic default imports in emitted code as well as in the type checker. See microsoft/TypeScript#9562.

That issue is now closed so I guess the README should change too?

@ds300
Copy link
Owner

ds300 commented Feb 20, 2018

Yes, thanks for the reminder! First I'll update the transformer to be able to run without babel if TS is >= 2.7

@ds300
Copy link
Owner

ds300 commented Apr 3, 2018

update on this: Last night I ripped out the babel transform, and ran in to this issue: microsoft/TypeScript#21621

Once that bug is solved I'll be happy to release react-native-typescript-transformer 2.0 which won't use babel at all and will only support React Native >= 0.52

wip branch over here: https://github.com/ds300/react-native-typescript-transformer/tree/no-babel

@henrikra
Copy link
Author

henrikra commented Apr 3, 2018

Sounds good!

@henrikra
Copy link
Author

@ds300 Looks like the issue is closed? So we are getting rid of babel now? :O

@ds300
Copy link
Owner

ds300 commented May 16, 2018

So so close! :D

Just need to wait for TS 2.9 to drop. Should be any day now 🤞

@skellock
Copy link

What a roller coaster.

  • Babel 7 will support TS! 😮 🎈🎉
  • but not all of it 😭 💥
  • Hey, let's remove babel! 😮 🎈🎉
  • But we can't cuz of a TS bug. 😢 💥
  • It's fixed!: 😮 🎈🎉
  • but we have to wait for 2.9 😪💥

You're killing me here David.

@ds300
Copy link
Owner

ds300 commented Jun 1, 2018

https://twitter.com/typescriptlang/status/1002230349521338368?s=19

🎊💃🕺🎉

Unfortunately I'm busy with non-tech stuff for a few days, but I'll work on a new release ASAP.

@JReinhold
Copy link

hey @ds300 , how's the 2.0 coming along? Honestly I'm just unsure if I should set "module": "es2015" in tsconfig or not, based on the info in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants