Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big twitter.json file #25

Closed
JonnyBurger opened this issue Oct 17, 2014 · 5 comments
Closed

Big twitter.json file #25

JonnyBurger opened this issue Oct 17, 2014 · 5 comments

Comments

@JonnyBurger
Copy link

This file in /samples is over 13MB big, and is not used. I feel like this is completely unnecessary, considering there are some packages that depend on this. It just bloats the package.
@dscape
Copy link
Owner

dscape commented Oct 17, 2014

Fix it

@dscape
Copy link
Owner

dscape commented Oct 17, 2014

Sorry that was too brief: Fix it and send a PR

@JonnyBurger
Copy link
Author

Only my second PR, hope it's fine. Decreased the amount of tweets in twitter.json

@dscape
Copy link
Owner

dscape commented Oct 17, 2014

Ah sorry that's not what I meant. You need the big file for performance tests.

What you can do is add a npmignore file, so that its not published to npm.

See : https://www.npmjs.org/doc/misc/npm-developers.html

@dscape
Copy link
Owner

dscape commented Oct 18, 2014

Can you reopen with the npm ignore file?

@dscape dscape closed this as completed Oct 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscape @JonnyBurger