Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlAudit: Some bugs in the unit tests #2002

Open
johlju opened this issue Feb 17, 2024 · 0 comments
Open

SqlAudit: Some bugs in the unit tests #2002

johlju opened this issue Feb 17, 2024 · 0 comments
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Feb 17, 2024 •
edited

This should not say 'not':

SqlServerDsc/tests/Unit/Classes/SqlAudit.Tests.ps1

Line 301 in 0ffc7ad

It 'Should not call method Modify()' {

This make Compare mock return wrong values:

SqlServerDsc/tests/Unit/Classes/SqlAudit.Tests.ps1

Lines 350 to 352 in 0ffc7ad

Name = 'MockAuditName'
InstanceName = 'NamedInstance'
Path = 'C:\WrongFolder'

It should return the same as here:

SqlServerDsc/tests/Unit/Classes/SqlAudit.Tests.ps1

Lines 290 to 292 in 0ffc7ad

Property = 'Path'
ExpectedValue = 'C:\NewFolder'
ActualValue = 'C:\Path'

@johlju johlju added help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub tests The issue or pull request is about tests only. labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju