Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Gateway Resource #18

Closed
tysonjhayes opened this issue Sep 3, 2015 · 6 comments
Closed

Create Gateway Resource #18

tysonjhayes opened this issue Sep 3, 2015 · 6 comments
Labels
discussion The issue is a discussion. enhancement The issue is an enhancement request.

Comments

@tysonjhayes
Copy link
Collaborator

Given that a gateway is set at the resource level, and DNS is already its own resource, I'm thinking it would make sense to set the default gateway as its own resource as well. This would break up the logic for the resources into more descrete components and allow more targeted changes in our code fixes and for setting the configuraiton.

Thoughts?

@tysonjhayes tysonjhayes added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. discussion The issue is a discussion. labels Sep 3, 2015
@iainbrighton
Copy link
Contributor

I agree that the gateway resource should be in a separate resource. There may be times you don't want to set a gateway (on a second NIC for example) but the IPAddress resource currently requires this!

@PlagueHO
Copy link
Member

👍
This change does make sense to me and would simplify a lot of my configs.

Presumably the schema would be something like this?

[ClassVersion("1.0.0"), FriendlyName("xGatewayAddress")] 
class MSFT_xGatewayAddress : OMI_BaseResource
{
  [Write] string Address;
  [Write, Description("Ensure the presence/absence of the resource"), ValueMap{"Present", "Absent"},Values{"Present", "Absent"}] String Ensure;
  [Key] string InterfaceAlias;
  [Key,Write,ValueMap{"IPv4", "IPv6"},Values{"IPv4", "IPv6"}] string AddressFamily;
};

I set both IPv4 and IPv6 gateways on the same interface usually so ideally it would support both :)

@tysonjhayes
Copy link
Collaborator Author

Yeah that seems pretty good to me. I won't have time for a bit to get started on it but if if anyone wants to take a pass I'd gladly do a code review.

@PlagueHO
Copy link
Member

I'm happy to take it on if it's good with you. After all, it'll simplify my configs :)

@tysonjhayes
Copy link
Collaborator Author

Consider it yours @PlagueHO. I would ask that part of your commit be to remove it from xIPAddress to satisfy #22. Otherwise your config looks good!

@tysonjhayes
Copy link
Collaborator Author

This is fixed, closing this out. Thanks everyone!

@vors vors removed the help wanted The issue is up for grabs for anyone in the community. label Sep 17, 2015
@SteveL-MSFT SteveL-MSFT added this to Discussion in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Discussion in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion The issue is a discussion. enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

4 participants