Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Parameters to MSFT_xFirewall Resource #53

Closed
PlagueHO opened this issue Nov 12, 2015 · 3 comments
Closed

Add Missing Parameters to MSFT_xFirewall Resource #53

PlagueHO opened this issue Nov 12, 2015 · 3 comments
Labels
enhancement The issue is an enhancement request.

Comments

@PlagueHO
Copy link
Member

The following parameters are missing from the MSFT_xFirewall resource and need to be added (after PR #52 has been merged):
DynamicTarget
EdgeTraversalPolicy
IcmpType
LocalOnlyMapping
LooseSourceMapping
OverrideBlockRules
Owner

At this point I don't think they are critical (unless someone needs them right now of course).
@tysonjhayes
Copy link
Collaborator

you wrote MSFT_xNetworking, did you mean xFirewall?

@PlagueHO
Copy link
Member Author

Yes. Yes I did. Corrected now. Sorry about that.

@tysonjhayes tysonjhayes changed the title Add Missing Parameters to MSFT_xNetworking Resource Add Missing Parameters to MSFT_xFirewall Resource Nov 13, 2015
@tysonjhayes tysonjhayes added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Nov 13, 2015
@PlagueHO PlagueHO mentioned this issue Dec 24, 2015
Merged
tysonjhayes pushed a commit that referenced this issue Dec 29, 2015
Merge pull request #74 from PlagueHO/Issue-53
c90bfdf 
Issue #53 - Add Missing Parameters to MSFT_xFirewall Resource
@PlagueHO
Copy link
Member Author

Closing. Thanks @tysonjhayes

@vors vors removed the help wanted The issue is up for grabs for anyone in the community. label Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tysonjhayes @vors @PlagueHO