Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Transloco v7 #19

Closed
BThomann opened this issue Apr 9, 2024 · 7 comments
Closed

Support for Transloco v7 #19

BThomann opened this issue Apr 9, 2024 · 7 comments

Comments

@BThomann
Copy link

BThomann commented Apr 9, 2024

Hello!
Just came across this nice library! Good job here!
Transloco is now published under a new scope jsverse https://github.com/jsverse/transloco.
This also resulted into a new version v7 with several breaking changes.
It would be great for this library to also support the new version of transloco, maybe also in the form of a new major version.
Thanks & BR B.

@dscheerens
Copy link
Owner

dscheerens commented Apr 9, 2024

Ah, thanks for bringing that to my attention. I will try to make a new release for that later today

@dscheerens
Copy link
Owner

Just released v6 of this library which supports Transloco v7. Note that it now also requires at least Angular v17 (was 16 previously).

@BThomann
Copy link
Author

Wow that was quick! Awesome work.
I just noticed that @ngneat/transloco is still part of the peerDependencies:
https://github.com/dscheerens/ngx-transloco-markup/blob/master/package.json#L36
Shouldn't this also be changed to the new scope & version?

@BThomann
Copy link
Author

And one suggestion: You could add the different scopes of the package also to the compatibility matrix as an additional information.

@dscheerens
Copy link
Owner

dscheerens commented Apr 10, 2024

I just noticed that @ngneat/transloco is still part of the peerDependencies

Oh, missed that one. Glad you noticed it. Fixed in the 6.0.1 6.0.2 release (just published)

And one suggestion: You could add the different scopes of the package also to the compatibility matrix as an additional information.

Good suggestion! Added that.

Thanks a lot for your input 👍

@BThomann
Copy link
Author

I have to thank you for your work you put into that project! 🚀

@Morente5
Copy link

Morente5 commented Jul 5, 2024

Just upgraded from Angular 13 and found @jsverse/transloco@7 is compatible with @angular/core@>=16.0.0 so there is an incompatible combination using this

  • @angular/core@16
  • @jsverse/transloco@7
  • ngx-transloco-markup@6
    I think versions of this library should cover the same compatibility options that transloco provides.

Thanks for your awesome libraries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants