New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests #114
Conversation
* Always check return value of ntfy_main (no longer using exceptions) * Do not use a dict as the default of args.option The latter accidentally shared state across tests, breaking all integration tests. However, this was hidden because exceptions are now caught and integration tests were not checking return values.
It's not clear to me where the |
b5c8601
to
d41f997
Compare
d41f997
to
62b3537
Compare
Pushed the changes to get CI working, not sure if most appropriate. |
1 similar comment
Awesome. thanks! That way of handling the xmpp req is fine :) |
The latter accidentally shared state across tests, breaking all
integration tests. However, this was hidden because exceptions are now
caught and integration tests were not checking return values.