Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-Gem class not working as expected #11

Closed
RedDVal opened this issue Sep 13, 2021 · 3 comments
Closed

Sub-Gem class not working as expected #11

RedDVal opened this issue Sep 13, 2021 · 3 comments

Comments

@RedDVal
Copy link

RedDVal commented Sep 13, 2021

Existing (but not working):
Show
Class Gem
Class Chipped Gem, Flawed Gem, Standard Gem
CharacterLevel <= 50

Working (but not intuitive)
Show
Class Gem
Class Chipped, Flawed, Standard
CharacterLevel <= 50

We should either update item.filter and class.md with "Chipped" instead of "Chipped Gem"
Or
Update code to correctly match "Class Chipped Gem"

@dschu012
Copy link
Owner

dschu012 commented Sep 13, 2021

ideally the fix is the 2nd. "Chipped Gem" should be the one I want to work so it matches https://github.com/fabd/diablo2/blob/master/code/d2_113_data/ItemTypes.txt#L94. ill see if i can take a look at some of these issues this week. thanks for all the testing.

@dschu012
Copy link
Owner

Do you have a save w/ said item that isn't working?

image

line 743 for me is

Show
    Class Gem
    Class Chipped Gem, Flawed Gem, Standard Gem
    CharacterLevel <= 50

@dschu012
Copy link
Owner

Closing issue. Reopen if it is still an issue on the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants