Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental line break causes crash #30

Open
qqkookie opened this issue Nov 20, 2022 · 0 comments
Open

Accidental line break causes crash #30

qqkookie opened this issue Nov 20, 2022 · 0 comments

Comments

@qqkookie
Copy link

qqkookie commented Nov 20, 2022

Original "item. filter" line 2551:

# 0/4os Eth Oath Bases (Oath)
Show
    Type Balrog Blade, Cryptic Sword, Feral Axe, Small Crescent, 
Conquest Sword, Highland Blade, Champion Sword
	Rarity < Magic
	Runeword False
	Ethereal True
	Sockets 0, 4
	SetStyle T6

I accidentally break the long "Types" line in middle into 2 lines, like
":... , Small Cescent," <newline> " Conquest Sword, ...."
then D2 crash on entering new session. Hard crash. No parse error message.
It is OK to insist Type line should be in single line, but it should not crash D2.

And it would be nice to have Type or Class in multi lines. Above example should be accepted as valid.
If parser see a comma symbol and no more non-blank symbol till end of line, then the list should continue to next line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant