Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] _writeMagicProperties alters the values array when writing the data to a d2s file #21

Closed
mgamperl opened this issue May 1, 2021 · 0 comments · Fixed by #27
Closed

Comments

@mgamperl
Copy link
Contributor

mgamperl commented May 1, 2021

_writeMagicProperties should not alter the values array when writing the data as the json object can not be used anymore afterwards

see dschu012's comment here

We could probably just use a variable to keep track of the index we're working with instead of doing property.values.shift() which is altering the array. i.e property.values[idx++] everytime we access it should likely work.

@mgamperl mgamperl changed the title _writeMagicProperties alters the values array when writing the data to a d2s file [Bug] _writeMagicProperties alters the values array when writing the data to a d2s file May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant