Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth fix #22

Merged
merged 13 commits into from Jun 22, 2021
Merged

Auth fix #22

merged 13 commits into from Jun 22, 2021

Conversation

nayakastha
Copy link
Member

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

Solves the existing issues with Authentication #8

鉂わ笍Thank you!

Build Status

pr-build-test

Copy link
Member

@SriramPatibanda SriramPatibanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When a wrong otp is entered, the snackbar isn't displayed and the app stays on the same page

WhatsApp Image 2021-06-21 at 9 13 47 PM
When a user enters wrong data and the warnings are displayed, there's a pixel overflow and that prevents the user from accessing the proceed button

@nayakastha
Copy link
Member Author

Check with 'run without debugging' for best results @SriramPatibanda

Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nayakastha op 馃帀

@abhibhaw abhibhaw merged commit 7818680 into dscnitrourkela:main Jun 22, 2021
@abhibhaw
Copy link
Member

@all-contributors please add @nayakastha for code, doc, ideas, projectManagement, maintenance

@allcontributors
Copy link
Contributor

@abhibhaw

I've put up a pull request to add @nayakastha! 馃帀

@abhibhaw
Copy link
Member

@all-contributors please add @abhibhaw for code, doc, ideas, projectManagement, maintenance

@allcontributors
Copy link
Contributor

@abhibhaw

I've put up a pull request to add @abhibhaw! 馃帀

@abhibhaw
Copy link
Member

@all-contributors please add @SriramPatibanda for code, doc, ideas, projectManagement, maintenance

@allcontributors
Copy link
Contributor

@abhibhaw

I've put up a pull request to add @SriramPatibanda! 馃帀

@abhibhaw abhibhaw linked an issue Jun 22, 2021 that may be closed by this pull request
@nayakastha nayakastha deleted the auth-fix branch June 22, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling of the user authentication
3 participants