Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate QuizPage with the app #54

Merged
merged 15 commits into from Aug 11, 2021
Merged

Integrate QuizPage with the app #54

merged 15 commits into from Aug 11, 2021

Conversation

SriramPatibanda
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Description

Integrate QuizPage with the app using the GraphQL APIs.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

Build Status

pr-build-test

@SriramPatibanda SriramPatibanda self-assigned this Aug 9, 2021
@SriramPatibanda SriramPatibanda requested review from abhibhaw and nayakastha and removed request for abhibhaw August 9, 2021 12:36
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

image image
Hello @SriramPatibanda , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

nayakastha
nayakastha requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@nayakastha nayakastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried running the app, but the code seems to work fine logically.
Just take care not to use absolute values for the sizes, padding and magins

aptiche/lib/utils/enums.dart
@@ -1 +1,3 @@
enum CurrentState { busy, ready }

enum ChoicesEnum { optionA, optionB, optionC, optionD, NON }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we will always have 4 options?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, not really sure

aptiche/lib/views/dataentry/dataentry.dart Outdated
@@ -264,6 +264,8 @@ class DataEntryScreen extends GetView<DataEntryController> {
width: SizeConfig.screenWidth,
alignment: Alignment.center,
child: CustomButton(
horizontalPadding: 15,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use relative values. SizeConfig

aptiche/lib/views/home/home_controller.dart
update();
}

@override
// ignore: unnecessary_overrides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this override needed? is onClose( ) compulsory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is kinda.

aptiche/lib/views/login/loginscreen.dart Outdated
@@ -117,6 +117,8 @@ class LoginView extends GetView<LoginController> {
)
else
CustomButton(
horizontalPadding: 15,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here as well. SizeConfig pls

@abhibhaw abhibhaw self-requested a review August 10, 2021 16:10
abhibhaw
abhibhaw approved these changes Aug 10, 2021
View reviewed changes
aptiche/lib/datamodels/api_models.dart
String explanation;
String? choice;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choice can be null? when?

@nayakastha nayakastha self-requested a review August 11, 2021 18:18
@github-actions
Copy link

image image
Hello @SriramPatibanda , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@nayakastha nayakastha merged commit 0a8e908 into dscnitrourkela:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhibhaw abhibhaw abhibhaw approved these changes

@riteshsp2000 riteshsp2000 riteshsp2000 approved these changes

@nayakastha nayakastha nayakastha approved these changes

Assignees

@SriramPatibanda SriramPatibanda

Labels
safe-for-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SriramPatibanda @abhibhaw @riteshsp2000 @nayakastha