Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with Post Properties Meta Box #119

Closed
miklb opened this issue Nov 24, 2017 · 3 comments
Closed

Errors with Post Properties Meta Box #119

miklb opened this issue Nov 24, 2017 · 3 comments

Comments

@miklb
Copy link
Contributor

miklb commented Nov 24, 2017

Currently on master (2.7.0) and when editing this post where I manually added the author name due to lack of mf2 properties, I get this stack trace in debug.log

[24-Nov-2017 18:21:02 UTC] PHP Warning:  Illegal string offset 'name' in /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/tabs/tab-author.php on line 13
[24-Nov-2017 18:21:02 UTC] PHP Stack trace:
[24-Nov-2017 18:21:02 UTC] PHP   1. {main}() /Users/miklb/Dev/miklb.dev/wp-admin/post.php:0
[24-Nov-2017 18:21:02 UTC] PHP   2. include() /Users/miklb/Dev/miklb.dev/wp-admin/post.php:174
[24-Nov-2017 18:21:02 UTC] PHP   3. do_meta_boxes() /Users/miklb/Dev/miklb.dev/wp-admin/edit-form-advanced.php:714
[24-Nov-2017 18:21:02 UTC] PHP   4. Kind_Tabmeta::display_metabox() /Users/miklb/Dev/miklb.dev/wp-admin/includes/template.php:1063
[24-Nov-2017 18:21:02 UTC] PHP   5. include_once() /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/class-kind-tabmeta.php:200
[24-Nov-2017 18:21:02 UTC] PHP   6. require_once() /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/tabs/tab-navigation.php:12
[24-Nov-2017 18:21:02 UTC] PHP Fatal error:  Uncaught Error: Only variables can be passed by reference in /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/tabs/tab-author.php:13
Stack trace:
#0 /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/tabs/tab-navigation.php(12): require_once()
#1 /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/class-kind-tabmeta.php(200): include_once('/Users/miklb/De...')
#2 /Users/miklb/Dev/miklb.dev/wp-admin/includes/template.php(1063): Kind_Tabmeta::display_metabox(Object(WP_Post), Array)
#3 /Users/miklb/Dev/miklb.dev/wp-admin/edit-form-advanced.php(714): do_meta_boxes(Object(WP_Screen), 'normal', Object(WP_Post))
#4 /Users/miklb/Dev/miklb.dev/wp-admin/post.php(174): include('/Users/miklb/De...')
#5 {main}
  thrown in /Users/miklb/Dev/miklb.dev/wp-content/plugins/indieweb-post-kinds/includes/tabs/tab-author.php on line 13

https://christianheilmann.com/2017/11/18/web-truths-the-web-is-better-than-any-other-platform-as-it-is-backwards-compatible-and-fault-tolerant/ is the Url retrieved in the meta box if you would like to test.

Let me know what else I can provide.

indieweb-post-kinds> php --version
PHP 7.1.11 (cli) (built: Oct 27 2017 11:00:03) ( NTS )
@dshanske
Copy link
Owner

Believe this is now fixed.

@miklb
Copy link
Contributor Author

miklb commented Nov 25, 2017

Not at least in my test environment, same fatal error and stack trace v2.7.1 and WordPress 4.9

@dshanske dshanske reopened this Nov 25, 2017
@miklb
Copy link
Contributor Author

miklb commented Dec 3, 2017

Fixed in 7d4fe99

@miklb miklb closed this as completed Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants