Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-column mode not working #14

Open
jackjamieson2 opened this issue Mar 22, 2019 · 0 comments
Open

Single-column mode not working #14

jackjamieson2 opened this issue Mar 22, 2019 · 0 comments

Comments

@jackjamieson2
Copy link

Maybe related to #13

If I'm understanding correctly, indieweb-publisher uses a universal indieweb_publisher_option() function to check each option from the customizer

This replaces multiple functions that indepenent publisher has for each option . e.g. independent_publisher_use_single_column_layout()

The problem is that indieweb_publisher_option only checks one option: "indieweb_publisher_general_options"

But some of the theme settings are saved in other options:

  • indieweb_publisher_excerpt_options
  • indieweb_publisher_layout_options

Two solution ideas:

  1. Merge all of the options into one field, either "indieweb_publisher_general_options" or simple "indieweb_publisher_options".
    Pros: Simple
    Cons: Potential for confusion if pulling in updates from independent publisher

  2. Create three functions to capture all three fields

  • indieweb_publisher_general_option
  • indieweb_publisher_excerpt_option
  • indieweb_publisher_layout_option

Each of these functions could check a specific option field.
Pros: Maintain consistence with independent publisher
Cons: A bit more work. Loses some of the clarity of single function solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant