Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commands] Return message object on EditResponseAsync #1774

Closed
BlackLotusLV opened this issue Feb 18, 2024 · 0 comments · Fixed by #1775
Closed

[Commands] Return message object on EditResponseAsync #1774

BlackLotusLV opened this issue Feb 18, 2024 · 0 comments · Fixed by #1775
Assignees
Labels
commands For issues related to DSharpPlus.Commands enhancement
Milestone

Comments

@BlackLotusLV
Copy link

Description

When editing a slash command response, on success it should return a DiscordMessage object. Currently it returns a ValueTask instead of ValueTask

https://discord.com/developers/docs/resources/webhook#edit-webhook-message

public virtual ValueTask EditResponseAsync(string content) => this.EditResponseAsync(new DiscordMessageBuilder().WithContent(content));
public virtual ValueTask EditResponseAsync(DiscordEmbed embed) => this.EditResponseAsync(new DiscordMessageBuilder().AddEmbed(embed));
public virtual ValueTask EditResponseAsync(string content, DiscordEmbed embed) => this.EditResponseAsync(new DiscordMessageBuilder().WithContent(content).AddEmbed(embed));
public abstract ValueTask EditResponseAsync(IDiscordMessageBuilder builder);

Specify the libraries you want this feature request to affect

DSharpPlus.Commands

Other considerations

No response

@Plerx2493 Plerx2493 added the commands For issues related to DSharpPlus.Commands label Feb 18, 2024
@Plerx2493 Plerx2493 added this to the v5.0 milestone Feb 18, 2024
@Plerx2493 Plerx2493 self-assigned this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands For issues related to DSharpPlus.Commands enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants