Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework reconnection logic #1921

Closed
Plerx2493 opened this issue May 25, 2024 · 1 comment · Fixed by #1971
Closed

Rework reconnection logic #1921

Plerx2493 opened this issue May 25, 2024 · 1 comment · Fixed by #1971
Assignees
Milestone

Comments

@Plerx2493
Copy link
Member

Plerx2493 commented May 25, 2024

Summary

New fields in Config:

  • uint MaximumReconnectionRetries
  • TimeSpan? ReconnectionDelayDuration (Static delay)
  • Func<uint attempt, TimeSpan result>? ReconnectionDelayGenerator (dynamic delay)

To be removed:

  • bool ReconnectIndefinitely

Defaults should have a implementation with some kind of hardlimit (maybe 15-30 min?)

Notes

Currently blocked by #1908

@Plerx2493 Plerx2493 added this to the v5.0 milestone May 25, 2024
@Plerx2493 Plerx2493 self-assigned this May 25, 2024
@akiraveliara
Copy link
Member

in the same spirit as #1909 , the duration should use a TimeSpan
and instead of the multiplier we might want to take a Func<TimeSpan initial, uint attempt, TimeSpan result>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants