Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NWJS v0.41.2 (latest) structure changed (build with nwjs-builder-phoenix) #46

Open
cry0m1 opened this issue Oct 3, 2019 · 1 comment

Comments

@cry0m1
Copy link
Contributor

cry0m1 commented Oct 3, 2019

  • While --swap is running (copy files from tmp to orig place) and 2nd restart to finish update process from NWJS 0.41.2 to 0.41.2, I am facing errors:

(unknown) Error: EEXIST: file already exists, mkdir '/Users/username/Application-0.10.14-22-mac-x64/Application.app/Contents/_CodeSignature' selfUpdate

(unknown) Error: Cannot copy 'Versions/Current/nwjs Framework' to a subdirectory of itself, 'Versions/Current/nwjs Framework'. at private/var/folders/2y/54plz59s5h73z1b46gnfdgwc0000gn/T/AppTranslocation/64F8F2E1-CC86-4509-9ED6-116D8B7488E2/d/Application.app/Contents/Resources/app.nw/node_modules/fs-extra/lib/copy/copy.js:190 at FSReqCallback.oncomplete (fs.js:154) selfUpdate
and update hangs forever.

I can suppose those by new folder structure inside nwjs with symlinks (found them by investigating binaries to sign by apple developer id):
WAS (I do not know exact version when it was changed):
Contents/Versions/*/nwjs\ Framework.framework/nwjs\ Framework Contents/Versions/*/nwjs\ Framework.framework/Versions/A/ Contents/Versions/*/nwjs\ Framework.framework/Versions/Current/ Contents/Versions/*/nwjs\ Helper.app/Contents/MacOS/nwjs\ Helper Contents/Versions/*/nwjs\ Framework.framework/Helpers/crashpad_handler Contents/MacOS/nwjs

NOW (NWJS v0.41.2 (latest) structure changed (build with nwjs-builder-phoenix 1.15.0 latest)):
Contents/Frameworks/nwjs\ Framework.framework/Versions/*/nwjs\ Framework Contents/Frameworks/nwjs\ Framework.framework/Versions/*/Helpers/nwjs\ Helper.app/Contents/MacOS/nwjs\ Helper Contents/Frameworks/nwjs\ Framework.framework/Versions/*/Helpers/nwjs\ Helper\ \(GPU\).app/Contents/MacOS/nwjs\ Helper\ \(GPU\) Contents/Frameworks/nwjs\ Framework.framework/Versions/*/Helpers/nwjs\ Helper\ \(Plugin\).app/Contents/MacOS/nwjs\ Helper\ \(Plugin\) Contents/Frameworks/nwjs\ Framework.framework/Versions/*/Helpers/nwjs\ Helper\ \(Renderer\).app/Contents/MacOS/nwjs\ Helper\ \(Renderer\) Contents/Frameworks/nwjs\ Framework.framework/Versions/*/Helpers/chrome_crashpad_handler Contents/Frameworks/nwjs\ Framework.framework/Versions/*/Helpers/app_mode_loader Contents/MacOS/Application

  • If from NWJS 0.37.4 to 0.41.2, I am facing only error:
    (unknown) Error: EEXIST: file already exists, mkdir '/Users/username/Application-0.10.14-22-mac-x64/Application.app/Contents/_CodeSignature' selfUpdate
    and update 2nd restart succeeds.

  • Earlier works without any issues at all.

NB: symbol '*' is:
drwx------ 9 badayka staff 288 Oct 1 17:19 77.0.3865.90 lrwxr-xr-x 1 badayka staff 12 Oct 1 17:19 Current -> 77.0.3865.90

I am not sure this is a problem of nw-autoupdater, maybe nwjs-builder-phoenix.

nw-autoupdater: 1.1.10 (latest)
nwjs-builder-phoenix: 1.15.0 (latest)

@cry0m1 cry0m1 changed the title NWJS v0.41.2 (latest) structure changed (build with nwjs-builder-phoenix 1.15.0 latest) NWJS v0.41.2 (latest) structure changed (build with nwjs-builder-phoenix) Oct 3, 2019
@cry0m1
Copy link
Contributor Author

cry0m1 commented Oct 3, 2019

Additionally:
I tried several version combinations:

  • nw-autoupdater v1.1.10
    nwjs v0.23.7
    nwjs v0.27.5
    nwjs v0.30.5
    nwjs v0.37.4
    nwjs v0.41.2

  • nw-autoupdater v1.1.8
    nwjs v0.23.7
    nwjs v0.27.5
    nwjs v0.30.5
    nwjs v0.37.4
    nwjs v0.41.2

result is the same:
(unknown) Error: Cannot copy 'Versions/Current/nwjs Framework' to a subdirectory of itself, 'Versions/Current/nwjs Framework'. at private/var/folders/2y/54plz59s5h73z1b46gnfdgwc0000gn/T/AppTranslocation/64F8F2E1-CC86-4509-9ED6-116D8B7488E2/d/Application.app/Contents/Resources/app.nw/node_modules/fs-extra/lib/copy/copy.js:190 at FSReqCallback.oncomplete (fs.js:154) selfUpdate

  • nw-autoupdater v1.1.6
    nwjs v0.41.2

works without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant