New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not push empty strings onto internal array #28

Closed

dsherret opened this issue May 20, 2019 · 0 comments

Labels

Owner

dsherret commented May 20, 2019

Would be better to first check the string length before pushing it onto the internal array.

dsherret added the performance label

dsherret referenced this issue


          perf: No longer pushes empty strings onto internal array.

4d46a72

dsherret closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment