Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $.setPrintCommand(true) to mutate configuration of a $ #22

Closed
dsherret opened this issue Oct 18, 2022 · 0 comments · Fixed by #23
Closed

Add $.setPrintCommand(true) to mutate configuration of a $ #22

dsherret opened this issue Oct 18, 2022 · 0 comments · Fixed by #23
Labels
enhancement New feature or request

Comments

@dsherret
Copy link
Owner

dsherret commented Oct 18, 2022

There are certain configuration settings that are useful to be able to mutate on an existing $ rather than constructing a new one. This mutable configuration should never be anything that could potentially break other code, but for logging purposes being able to modify if a command is printed to the console seems useful.

So instead of:

import { build$, CommandBuilder } from "...";

const $ = build$({
  commandBuilder: new CommandBuilder().printCommand(),
});

Users could do:

import { $ } from "...";

$.setPrintCommand(true);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant