Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate caching wasm file #32

Closed
dsherret opened this issue Dec 3, 2022 · 2 comments · Fixed by #36
Closed

Investigate caching wasm file #32

dsherret opened this issue Dec 3, 2022 · 2 comments · Fixed by #36
Labels
enhancement New feature or request

Comments

@dsherret
Copy link
Owner

dsherret commented Dec 3, 2022

IIRC, I think right now it downloads on every run? Not good. (maybe this just requires updating wasmbuild)

@dsherret dsherret added the enhancement New feature or request label Dec 3, 2022
@andrewbrey
Copy link
Contributor

I learned this on an airplane last weekend! Indeed, as of now, some wasm file is downloaded every run and so even if you cache the other modules in the graph, network access is still required to run dax code - documenting or mitigating this would be very helpful 👍

@dsherret
Copy link
Owner Author

dsherret commented Dec 3, 2022

I also discovered this while on an airplane 😅

I'm going to mitigate it for now (shouldn't be up to the user to have to worry about this). Soon Deno will support wasm files as being part of the module graph so the whole situation will be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants