Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pinned esm.sh modules? #230

Closed
dchambers opened this issue Oct 24, 2022 · 1 comment 路 Fixed by #246
Closed

Support for pinned esm.sh modules? #230

dchambers opened this issue Oct 24, 2022 · 1 comment 路 Fixed by #246
Labels
bug Something isn't working

Comments

@dchambers
Copy link

Hi 馃憢.

Firstly, thanks so much for making this awesome tool! This may not be something in your power to address, but I thought I'd create a ticket since there doesn't yet seem to be one on the topic of version pinning within the ESM CDN.

So for context, I recently discovered that the latest version of ESM (v96) has a regression that breaks support for the graphql module, which I've just now reported here:

I can fix the tests by pinning the version back to v95 (achieved by adding a ?pin=v95 suffix to the ESModule URL) however, but doing this causes my build to fail with the following error:

panicked at 'dnt bug - Could not find mapping for types code specifier https://esm.sh/v95/graphql@16.5.0/error/GraphQLError.d.ts', rs-lib\src\mappings.rs:97:9

Any thoughts / suggestions here would be very much appreciated?

@dsherret dsherret added the bug Something isn't working label Jan 9, 2023
@dsherret dsherret changed the title Support for pinned ESM modules? Support for pinned esm.sh modules? Jan 9, 2023
@dchambers
Copy link
Author

Thank you so much for fixing this 鉂わ笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants