Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use package name instead of directory basename for workspace #29

Closed
n1ru4l opened this issue Jan 14, 2019 · 1 comment
Closed

use package name instead of directory basename for workspace #29

n1ru4l opened this issue Jan 14, 2019 · 1 comment

Comments

@n1ru4l
Copy link

n1ru4l commented Jan 14, 2019

I think this are the relevant lines:

workspaces+=("$(basename "$workspace_path")")

The package name of a workspace package is not always equal to the folder name. E.g. a scoped package @organisation/foobar could be located under packages/foobar.

yarn-completion only completes with foobar instead of @organisation/foobar.

Therefore yarn-completion should rely on parsing the package name from the actual package.json of the workspace package.

@n1ru4l n1ru4l changed the title use package name instead of dirctory basename for workspace use package name instead of directory basename for workspace Jan 14, 2019
@dsifford
Copy link
Owner

Good point. I'll look into getting this fixed as soon as I get some free time. PRs accepted also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants