Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-handed mode feature #545

Merged
merged 11 commits into from
Mar 1, 2022
Merged

One-handed mode feature #545

merged 11 commits into from
Mar 1, 2022

Conversation

MajeurAndroid
Copy link
Member

@MajeurAndroid MajeurAndroid commented Feb 20, 2022

This needs to be tested, especially on non qwerty configs (because I never use them :)). Feel free to comment with your feedbacks and, if needed, some screenshots.
You'll find an APK to test under the "Checks" tab, inside the artifact menu.

The amount of width reduction in one-handed mode is currently 86%, I only tested this on a regular phone. This value can (and must) be adapted to other configurations, such as tablets. Feel free to provide some feedbacks about how it feels on other devices.

Here is a preview:
ezgif-2-0a66ae60b3

Fixes #13
Partially fixes #229
Fixes #523

@SosPosos @hiru12 @kojid0 @mad1mystic @qw123wh you guys might be interested by this.

@qw123wh
Copy link
Contributor

qw123wh commented Feb 20, 2022

hi, I can't find the apk

@MajeurAndroid
Copy link
Member Author

@qw123wh you'll find it there:
capture

@qw123wh
Copy link
Contributor

qw123wh commented Feb 20, 2022

@MajeurAndroid I download a file called “APK.zip” the problem is that it doesn't let me extract it. Publish an apk as a pre-release or send a link. I also tried to compile it with Android studio but I couldn't

@qw123wh
Copy link
Contributor

qw123wh commented Feb 20, 2022

@MajeurAndroid to extract the archive "APK.zip" it asks me for a password, what is the password?

@MajeurAndroid
Copy link
Member Author

@qw123wh if by "extracted" you meant install the apk, it should be fixed now. Try to re-download the apk, it should be signed. For the password, I have no idea what you're talking about, the archive is a regular zip.

@qw123wh
Copy link
Contributor

qw123wh commented Feb 20, 2022

@MajeurAndroid it is a file .zip , but it is password protected. Try to download this .zip file yourself, then try to extract it and it will ask you for a password

@dslul
Copy link
Member

dslul commented Feb 21, 2022

@MajeurAndroid it is a file .zip , but it is password protected. Try to download this .zip file yourself, then try to extract it and it will ask you for a password

I have no issue with the archive, it works fine

@qw123wh
Copy link
Contributor

qw123wh commented Feb 21, 2022

@MajeurAndroid @dslul I had a problem I could not download the file correctly, I don't know what caused it sorry, now everything is ok.
Back to the app, I tested it on 3 smartphones, and on 1 tablet. On the following smartphones “Redmi 9A android 9 (miui), redmi note 8 android 10 aosp, redmi note 7 android 12 aosp. The Tablet is Samsung galaxy s2 (8 inch version) android 7.

On redmi 9a and redmi note 7 the one-handed mode works perfectly both in portrait and landscape.

On redmi note 8 it works well only in portrait mode, (here I think it is a problem of custom rom, or an android 10 problem)

On Samsung s2 tablet with android 7 and original samsung rom it does not work neither in landscape nor in portrait mode, and in addition, the number line does not appear. I only have this android tablet, I don't know if it works fine on other tablets

@MajeurAndroid
Copy link
Member Author

@qw123wh thanks, can you elaborate and describe what is not working on your tablet ? Maybe with screenshots.

@qw123wh
Copy link
Contributor

qw123wh commented Feb 21, 2022

@MajeurAndroid This is the behavior of the app on the tablet ( the number line option is also enabled, but it doesn't work) Screenrecorder

2022_02_21_09_16_58.mp4

@qw123wh
Copy link
Contributor

qw123wh commented Feb 21, 2022

@MajeurAndroid perhaps this is better seen
https://user-images.githubusercontent.com/59417474/155024295-d6b12264-b17d-4e9b-8102-d22176136aeb.MP4

@MajeurAndroid
Copy link
Member Author

MajeurAndroid commented Feb 28, 2022

@qw123wh thanks, this is now fixed in 500c8eb. This one was tricky, the bug causing the issue is from Google itself ! I am really surprised it has not been fixed before!
For those interested, here is the bug visible in Google's android repo: https://android.googlesource.com/platform/packages/inputmethods/LatinIME/+/refs/heads/master/java/src/com/android/inputmethod/keyboard/internal/MoreKeySpec.java#301

@qw123wh
Copy link
Contributor

qw123wh commented Feb 28, 2022

@MajeurAndroid perfect I tested the new apk and now everything works fine even on the tablet. Google makes many disasters, fixes bugs in proprietary apps (gboard) and ditches aosp counterparts

@MajeurAndroid MajeurAndroid merged commit 9adc4f6 into master Mar 1, 2022
@MajeurAndroid MajeurAndroid deleted the feature-one-handed-mode branch March 9, 2022 08:39
@ItsRogueRen
Copy link

I cannot for the life of me find how to enable this, I have the latest build in the releases page but don't have any settings for a one-handed mode. Clearly this has been added, but either it isn't in the current release or is horrible placed to where you can't find it unless you know where to look

@jnnkB
Copy link
Collaborator

jnnkB commented Jun 26, 2022

Since the lastest release is from January and this PR only got merged in March, I'm pretty sure its not included. But you should be able to use the APK from the artifacts of last Github Actions run: https://github.com/openboard-team/openboard/actions?query=branch%3Amaster.

@ItsRogueRen
Copy link

Since the lastest release is from January and this PR only got merged in March, I'm pretty sure its not included. But you should be able to use the APK from the artifacts of last Github Actions run: https://github.com/openboard-team/openboard/actions?query=branch%3Amaster.

I still seem to be missing a setting for one-handed mode even with that latest build

@Helium314
Copy link
Contributor

Helium314 commented Jun 30, 2022

I still seem to be missing a setting for one-handed mode even with that latest build

See the gif/video in the first post: try a long press on comma key

@MajeurAndroid
Copy link
Member Author

@ItsRogueRen it's avilable as shown in the gif inside PR's description, can you try with an english keyboard ? If it is still not working, you might not have the latest release.

@ItsRogueRen
Copy link

@ItsRogueRen it's avilable as shown in the gif inside PR's description, can you try with an english keyboard ? If it is still not working, you might not have the latest release.

I got it, it didn't actually install the first time around and I didn't realize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants