Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestion, and optimize keyboard height #750

Closed
wants to merge 2 commits into from

Conversation

odmfl
Copy link

@odmfl odmfl commented Jan 3, 2023

optimize keyboard height,and fix suggestions
problems not visible in many apps like
playstore, kiwi browser, etc

Fix #660 #745 #747 #731 #275 #418 #507 #345

@odmfl odmfl mentioned this pull request Jan 3, 2023
@RHJihan
Copy link
Contributor

RHJihan commented Jan 4, 2023

As far as I have tested, the suggestion strip is not showing on Google Chrome, Facebook Messenger, Samsung Contacts, and Keepass2Android.

Google Chrome Facebook Messenger Samsung Contacts Keepass2Android

@odmfl
Copy link
Author

odmfl commented Jan 4, 2023

@RHJihan You don't have to write in the address bar of the browser, only it doesn't appear there, but it doesn't appear with the aosp keyboard either. Then that should only be used to type a manual url, go to the google or other page and write from there.

@odmfl
Copy link
Author

odmfl commented Jan 4, 2023

before even looking on the play store it didn't work, however I will do some tests and see if I can solve it

@RHJihan
Copy link
Contributor

RHJihan commented Jan 4, 2023

I wanted to see this from a user's point of view. As a user, I would prefer to see suggestions everywhere as I get them on Gboard or Samsung Keyboard.
If the AOSP keyboard works the same, I think it should not be implemented as it is.

@Helium314
Copy link
Contributor

The keyboard changes are basically reverting #562 and adding even more restrictions, so of course the old problems are back again.

I think the only real fix is #709, so there needs to be a setting...

@odmfl
Copy link
Author

odmfl commented Jan 4, 2023

Ok, I did this and now it works for all of them, however with commit #562 it didn't work for me either on the play store, for this reason I had done a sort of revert, then it worked for me on the playstore and others and I thought it was solved, now I did as you suggested and it works perfectly. It just has to be merged. However there are 2 PRs of mine almost duplicates, I think I will close this one and do everything in the other one. Try the apk and let me know

https://github.com/odmfl/openboard/suites/10183816163/artifacts/498264752

@RHJihan
Copy link
Contributor

RHJihan commented Jan 4, 2023

Yes, the last fix works perfectly.

@RHJihan
Copy link
Contributor

RHJihan commented Jan 10, 2023

@odmfl, did you add this commit to this PR yet?

@odmfl
Copy link
Author

odmfl commented Jan 11, 2023

full PR is #749, 750 is a copy and should be deleted

@RHJihan
Copy link
Contributor

RHJihan commented Jan 11, 2023

@odmfl, so you would like to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions not showing everywhere.
3 participants