-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suggestion, and optimize keyboard height #750
Conversation
problems not visible in many apps like playstore, kiwi browser... Fix openboard-team#660 openboard-team#745 openboard-team#747 openboard-team#275 openboard-team#418 openboard-team#507 openboard-team#345
As far as I have tested, the suggestion strip is not showing on Google Chrome, Facebook Messenger, Samsung Contacts, and Keepass2Android.
|
@RHJihan You don't have to write in the address bar of the browser, only it doesn't appear there, but it doesn't appear with the aosp keyboard either. Then that should only be used to type a manual url, go to the google or other page and write from there. |
before even looking on the play store it didn't work, however I will do some tests and see if I can solve it |
I wanted to see this from a user's point of view. As a user, I would prefer to see suggestions everywhere as I get them on Gboard or Samsung Keyboard. |
Ok, I did this and now it works for all of them, however with commit #562 it didn't work for me either on the play store, for this reason I had done a sort of revert, then it worked for me on the playstore and others and I thought it was solved, now I did as you suggested and it works perfectly. It just has to be merged. However there are 2 PRs of mine almost duplicates, I think I will close this one and do everything in the other one. Try the apk and let me know https://github.com/odmfl/openboard/suites/10183816163/artifacts/498264752 |
Yes, the last fix works perfectly. |
full PR is #749, 750 is a copy and should be deleted |
@odmfl, so you would like to close this PR. |
optimize keyboard height,and fix suggestions
problems not visible in many apps like
playstore, kiwi browser, etc
Fix #660 #745 #747 #731 #275 #418 #507 #345