Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Adapters: Remove duplicate code #106

Open
EsipovPA opened this issue Oct 3, 2023 · 0 comments
Open

[Improvement] Adapters: Remove duplicate code #106

EsipovPA opened this issue Oct 3, 2023 · 0 comments

Comments

@EsipovPA
Copy link

EsipovPA commented Oct 3, 2023

Current state
It seems to me that the code in the methods __load_tree of the inotifyTree and inotifyTrees classes is being duplicated.
If I'm not being wrong, it is possible to convert this code into a method of the parent class __BaseTree and add some more parameters for child classes to call it, like debug_message.

Better way to do it?
Move duplicated code to __BaseTree class. Maybe do some refactoring.

Motivation
Better readability, easier support.

TODO?
If nobody is up to this, and nobody is against it, I'm willing to add this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant