Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReconnectAfterMs is too big #40

Closed
ostap0207 opened this issue Feb 21, 2019 · 1 comment
Closed

ReconnectAfterMs is too big #40

ostap0207 opened this issue Feb 21, 2019 · 1 comment

Comments

@ostap0207
Copy link
Contributor

JS version goes up to 10 seconds https://github.com/phoenixframework/phoenix/blob/master/assets/js/phoenix.js#L729,
here we go up to 100 seconds https://github.com/dsrees/JavaPhoenixClient/blob/master/src/main/kotlin/org/phoenixframework/PhxSocket.kt#L49.
Is that on purpose or a simple typo?
@dsrees
Copy link
Owner

dsrees commented Feb 21, 2019

that would be a typo

ostap0207 added a commit to salemove/JavaPhoenixClient that referenced this issue Feb 21, 2019
@ostap0207
Fix max reconnectAfterMs
33c9a31 
Fixes: dsrees#40
@ostap0207 ostap0207 mentioned this issue Feb 21, 2019
Merged
dsrees pushed a commit that referenced this issue Feb 21, 2019
@ostap0207 @dsrees
Fix max reconnectAfterMs (#41)
67baf71 
Fixes: #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ostap0207 @dsrees