Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

Helper functions for preparing sunpy.map.Map objects for pfsspy.Input #169

Closed
STBadman opened this issue Apr 23, 2020 · 9 comments
Closed
Labels
Enhancement New feature or request
Milestone

Comments

@STBadman
Copy link
Contributor

Roll Function
Take sunpy.map.Map instance, verify is synoptic map, edit Map.data (inplace?) : roll carrington longitude = 0 to LH edge of map

Interpolate to sinlat function
Take sunpy.map.Map instance, verify is synoptic map, verify latitudinal binning is not sinlat, edit Map.data (inplace?) : interpolate data to uniform binning in sinlat (same dimensions as previous?)

@STBadman
Copy link
Contributor Author

@dstansby would another helper function titled something like load_adapt be appropriate in this development? It would take a path to an adapt .fts file as input and returns a MapSequence as in #170 , I'm writing it for local convenience but can submit it in a PR if you think it's useful?

@dstansby
Copy link
Owner

Yes, that sounds useful!

@dstansby
Copy link
Owner

@STBadman I've got the CEA reprojection working well here: #199, if you want to add any comments on the PR feel free (I still have to expand the gallery example). I'm thinking about how to test this. Total flux should be conserved, which I will add as a test, but do you have any ideas for other tests that could be added?

@dstansby dstansby added this to the 0.6.0 milestone Jul 3, 2020
@STBadman
Copy link
Contributor Author

STBadman commented Jul 3, 2020

Sorry I didn't get to giving feedback yet but I saw the PR was closed, are you adding it to a future PR?

@dstansby
Copy link
Owner

dstansby commented Jul 5, 2020

Woops, I didn't mean to close that... will re-open it.

@dstansby dstansby modified the milestones: 0.6.0, 1.0.0 Sep 15, 2020
@dstansby dstansby reopened this Sep 18, 2020
@dstansby
Copy link
Owner

I think the status here is there still needs to be a roll function?

@dstansby dstansby modified the milestones: 1.0.0, Future May 17, 2021
@STBadman
Copy link
Contributor Author

I think that's right. I think in our last correspondence on this you mentioned this could be accomplished within reproject. Are you familiar enough with reproject to do this quickly? I'm happy to take a look otherwise.

@dstansby
Copy link
Owner

The car_to_cea function in pfsspy/utils.py uses a reproject approach. The nice thing is, if you know how to modify the FITS header to get the desired result, the reproject option is pretty easy to modify. So if you want to have a go, it should be pretty easy to copy car_to_cea, and just change how the FITS header is modified. Make sure to grab the latest version of the code, I just cleaned up car_to_cea, and I've also renamed the master branch to main.

@dstansby
Copy link
Owner

Fixed by #296

@dstansby dstansby modified the milestones: Future, 1.1.0 Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants