Add conversion to/from NumPy structured arrays #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! What's the most common use-case for this? |
|
I feel it's important to have bridges to well established tools that folks are familiar with already. NumPy is certainly a de-facto standard! Once you have a numpy array, you can save the file to disk for example, and load it back up. A whole lot of standard tools become available to you. |
|
Cool! |
SamLau95
added a commit
that referenced
this pull request
Oct 20, 2015
Add conversion to/from NumPy structured arrays
SamLau95
added a commit
that referenced
this pull request
Oct 21, 2015
In #129 we removed Table.matrix from the API. However, Table.bin still used the method. This fixes Table.bin. There are no other places that I know of that use Table.matrix, so hopefully this is the last time we'll have to do something like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR also removes
t.matrix, which returned a somewhat broken matrix object (matrices are not recommended for use, and in this case the column dtype was simply being taken from the first column, turning numbers into strings, etc.)