Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with @hapi/joi@15 #2

Closed
deyvsh opened this issue May 17, 2019 · 10 comments
Closed

Incompatibility with @hapi/joi@15 #2

deyvsh opened this issue May 17, 2019 · 10 comments

Comments

@deyvsh
Copy link

deyvsh commented May 17, 2019

Hi, thanks very much for sharing your code - it's really useful!

I just tried an upgrade to latest major joi version (@hapi/joi@15) and now this line:

JoiWithSemver = Joi.extend(require("joi-extension-semver"));

throws this exception:

"base" must be an instance of "Joi object"

I'm in a rush right now but wanted to leave a warning in case anyone else hits the same problem. If I get a chance to research more I'll update this issue.

@sidjai
Copy link

sidjai commented May 18, 2019

Yep get the same error when updated to joi 15

@dszakallas
Copy link
Owner

Yikes! I sure could use a helping hand with this, I haven't developed in nodejs for a while.

@paulmelnikow
Copy link
Collaborator

@dszakallas Would you mind adding me and/or @chris48s to the repo and the npm project? Speaking for myself at least, I can say I'd be happy to maintain this. Chris and I work together on https://shields.io/.

@paulmelnikow
Copy link
Collaborator

Also if you'd prefer a pull request we could go that route!

@dszakallas
Copy link
Owner

Thanks @paulmelnikow for the help. I'll add you as maintainer in a sec.

@paulmelnikow
Copy link
Collaborator

Thanks! We're getting this going. Should have the release ready momentarily.

This is my account on npmjs: https://www.npmjs.com/~paulmelnikow

@paulmelnikow
Copy link
Collaborator

Ready to publish!

@paulmelnikow
Copy link
Collaborator

Hi @dszakallas, would you mind giving me publish access so I can wrap this up? Thanks!

@dszakallas
Copy link
Owner

@paulmelnikow I added you right now.

@paulmelnikow
Copy link
Collaborator

Published! https://www.npmjs.com/package/joi-extension-semver 🚀

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants