Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interface for translating Xarray object attributes to MET attributes #1470

Open
18 tasks
DanielAdriaansen opened this issue Aug 25, 2020 · 1 comment
Open
18 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required MET: Python Embedding priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented Aug 25, 2020

Describe the Enhancement

Users who choose to use Xarray objects with Python embedding will almost certainly arrive at the MET tools with an Xarray object that already has attributes attached to it. To streamline the user experience with Python embedding and Xarray, consider developing a way to decipher the attributes associated with the users Xarray object and make them conform to the MET standard for attributes expected for Python embedding. The current implementation of this feature requires the user to develop these attributes from scratch using the MET standards, remove their existing attributes from the Xarray object, and attach the MET-compliant attributes they created from scratch. It's likely many of the items MET is looking for already exist in the attributes the user will arrive with.

Time Estimate

2-3 days

Relevant Deadlines

NONE

Funding Source

NONE

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop and link the pull request to this issue..
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added type: enhancement Improve something that it is currently doing component: python interface priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Aug 25, 2020
@DanielAdriaansen DanielAdriaansen added this to the MET 10.0 milestone Aug 25, 2020
@DanielAdriaansen DanielAdriaansen self-assigned this Aug 25, 2020
@DanielAdriaansen DanielAdriaansen added this to To do in MET-10.0.0-beta1 (10/22/20) via automation Aug 25, 2020
@DanielAdriaansen
Copy link
Contributor Author

Most (all?) of the attributes MET needs for Python embedding appear to be in the dataplane_from_numpy_array class here:
https://github.com/dtcenter/MET/blob/master_v9.1/met/src/libcode/vx_data2d_python/dataplane_from_numpy_array.cc

@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Sep 10, 2020
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Nov 5, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in MET-10.0.0-beta3 (1/27/21) via automation Nov 5, 2020
@JohnHalleyGotway JohnHalleyGotway added this to To do in MET-10.0.0-beta4 (3/2/21) via automation Jan 25, 2021
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED MORE DEFINITION Not yet actionable, additional definition required label Feb 9, 2021
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required MET: Python Embedding priority: low Low Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants