Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the requirements.txt file #276

Closed
21 tasks
bikegeek opened this issue Feb 14, 2023 · 1 comment
Closed
21 tasks

Update the requirements.txt file #276

bikegeek opened this issue Feb 14, 2023 · 1 comment
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METcalcpy: General priority: high High Priority requestor: METplus Team METplus Development Team type: task An actionable item of work

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Feb 14, 2023

The requirements.txt file is out-of-date and no longer consistent with the METplotpy requirements.txt.

Update the third-party Python package versions for Python 3.10.4 Create an environment.yaml file for users who use conda. It is not necessary to create an nco_environment.yaml file.

Describe the Task

Found discrepancy in the version with METplotpy for imageio, metpy, netCDF4, numpy, and pandas:

From @jprestop:

imageio
This is listed as 2.19.3 in plotpy requirements.txt, but 2.6.1 in calcpy requirements.txt. Should we update the calcpy requirements.txt file?

metpy
This is listed as 1.3.1 in calcpy and plotpy nco_requirements.txt, but as 1.1.0 in calcpy requirements.txt. Should we update the calcpy requirements.txt file?

netCDF4
_This is listed as 1.6.0 in METplotpy nco_requirements.txt and in plotpy requirements.txt, but 1.5.7 in calcpy requirements.txt and 1.6.2 in calcpy nco_requirements.txt. Should we update the calcpy requirements.txt and calcpy nco_requirements.txt or should the value here be 1.6.2 and should we update everywhere else? (Let's use the 1.6.2 version in both METcalcpy and METplotpy, for the NCO requirements and other requirements.txt files)

numpy:
This is listed as 1.22.0 in nco_requirements.txt, 1.22.3 in calcpy requirements.txt. I'm not sure which one we need and if we should update elsewhere._

pandas:
1.5.1 in calcpy, plotpy and dataio nco_requirements.txt and 1.5.1 in plotpy and dataio requirements.txt, but 1.2.3 in calcpy requirements.txt. Should we update in calcpy requirements.txt?

Verify that the versions are consistent with the NCO versions and METplotpy versions.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: task An actionable item of work alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Feb 14, 2023
@bikegeek bikegeek added this to the METcalcpy 2.1.0 beta1 milestone Feb 14, 2023
@bikegeek bikegeek added priority: high High Priority requestor: METplus Team METplus Development Team METcalcpy: General and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Feb 14, 2023
@bikegeek
Copy link
Collaborator Author

bikegeek commented Mar 1, 2023

performed during upgrade to Python 3.10 Issue #270

@bikegeek bikegeek closed this as completed Mar 1, 2023
@JohnHalleyGotway JohnHalleyGotway modified the milestones: METcalcpy 2.1.0 beta1, METcalcpy 2.1.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METcalcpy: General priority: high High Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
Status: Done
Development

No branches or pull requests

3 participants