Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC-RMW plot needs updating to support changes to input #425

Closed
23 tasks
bikegeek opened this issue Mar 5, 2024 · 3 comments
Closed
23 tasks

TC-RMW plot needs updating to support changes to input #425

bikegeek opened this issue Mar 5, 2024 · 3 comments
Assignees
Labels
component: input data Input data issue METplotpy: Plots priority: high High Priority requestor: DTC/T&E General DTC Testing and Evaluation work required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: bug Fix something that is not working

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Mar 5, 2024

Describe the Problem

When using updated TC-RMW data, the METplotpy TC-RMW plot for the cross-section is raising errors like the following:
TypeError Length of x(100) must match number of columns in z(3) and other similar dimension mismatch TypeError messages.

Changes to the order of the dimensions in dtcenter/METcalcpy#308
are not supposed to impact the contour plot, but the contour plot is sensitive to this.

Expected Behavior

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@bikegeek bikegeek added type: bug Fix something that is not working priority: high High Priority requestor: DTC/T&E General DTC Testing and Evaluation work required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METplotpy: Plots component: input data Input data issue labels Mar 5, 2024
@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Mar 5, 2024
@bikegeek bikegeek self-assigned this Mar 5, 2024
@bikegeek
Copy link
Collaborator Author

bikegeek commented Mar 5, 2024

Two changes need to be made in the plot_cross_section.py code:

  • when calculating the field_azi_mean, set axis=0 instead of 1

  • for the Z value in the contour plot, use the field_azi_mean rather than the field_azi_mean.transpose to get the correct dimensions for the contour plot.

@bikegeek
Copy link
Collaborator Author

bikegeek commented Mar 5, 2024

Instructions for performing the vertical interpolation and generating the cross-plot on 'seneca':
README.txt

@mrinalbiswas
Copy link

I have tested the changes on seneca and it ran successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: input data Input data issue METplotpy: Plots priority: high High Priority requestor: DTC/T&E General DTC Testing and Evaluation work required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: bug Fix something that is not working
Projects
Status: Done
Development

No branches or pull requests

2 participants