Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Add modulefiles used for installations on various machines #1749

Closed
16 of 22 tasks
jprestop opened this issue Aug 16, 2022 · 4 comments · Fixed by #1750
Closed
16 of 22 tasks

Internal: Add modulefiles used for installations on various machines #1749

jprestop opened this issue Aug 16, 2022 · 4 comments · Fixed by #1750
Assignees
Labels
component: user support User support issue priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Milestone

Comments

@jprestop
Copy link
Collaborator

jprestop commented Aug 16, 2022

Describe the Task

Add the modulefiles used for installations on various machines to the repository for reference and backup, to internal/scripts/installation/modulefiles.

Time Estimate

< 1 day of work

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

NONE

Funding Source

2792541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added priority: medium Medium Priority type: task An actionable item of work component: user support User support issue requestor: METplus Team METplus Development Team labels Aug 16, 2022
@jprestop jprestop added this to the METplus-5.0.0 milestone Aug 16, 2022
@jprestop jprestop self-assigned this Aug 16, 2022
@georgemccabe
Copy link
Collaborator

This work should be done at the same time as or shortly after #1748

@jprestop jprestop changed the title Add modulefiles used for installations on various machines Internal: Add modulefiles used for installations on various machines Aug 16, 2022
@jprestop
Copy link
Collaborator Author

@georgemccabe I have completed the work in a branch. I wasn't sure why it needed to be done at the same time or after #1748, but I can wait to submit the PR (doing a pull from develop once #1748 is done) if you'd like.

@georgemccabe
Copy link
Collaborator

@jprestop, I suppose it doesn't need to be done with #1748, but there will be both internal and internal_tests directories if you merge your changes before the other issue is completed. That shouldn't be a problem though.

@jprestop jprestop linked a pull request Aug 17, 2022 that will close this issue
14 tasks
@jprestop
Copy link
Collaborator Author

@georgemccabe Thanks. I went ahead and submitted a PR and assigned you as the reviewer. No rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: user support User support issue priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants