Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update use cases to use new Python directory structure in MET #2115

Closed
22 tasks
DanielAdriaansen opened this issue Apr 11, 2023 · 1 comment · Fixed by #2133
Closed
22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: task An actionable item of work
Milestone

Comments

@DanielAdriaansen
Copy link
Contributor

In dtcenter/MET#2285, many changes to the location of the scripts used for Python embedding have happened. When this change gets merged to the MET develop branch, the use cases in METplus will fail until they are updated to adopt to the new structure.

Describe the Task

Review all METplus met_tool_wrapper and model_applications use cases that use Python Embedding to ensure they are not failing with the new structure.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added type: task An actionable item of work alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Apr 11, 2023
@DanielAdriaansen DanielAdriaansen self-assigned this Apr 11, 2023
@jprestop
Copy link
Collaborator

@DanielAdriaansen could you please add the appropriate metadata for this issue?

@DanielAdriaansen DanielAdriaansen added this to the METplus-5.1.0 milestone Apr 18, 2023
@georgemccabe georgemccabe changed the title Update use cases to use new Python directory structure in MET Internal: Update use cases to use new Python directory structure in MET Apr 26, 2023
@georgemccabe georgemccabe changed the title Internal: Update use cases to use new Python directory structure in MET Enhancement: Update use cases to use new Python directory structure in MET Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: task An actionable item of work
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants