Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using Docker Data Volumes for testing #567

Closed
19 tasks
georgemccabe opened this issue Aug 17, 2020 · 1 comment · Fixed by #810
Closed
19 tasks

Investigate using Docker Data Volumes for testing #567

georgemccabe opened this issue Aug 17, 2020 · 1 comment · Fixed by #810
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: CI/CD Continuous integration and deployment issues component: testing Software testing issue priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Docker data volumes could be used to not only store input data required to run tests, but to store "truth" output and new test output so that they can be compared. We should investigate how this would be done through Travis. The MET nightly build system has functionality to save the "truth" version commit to compare new output runs. This could be used as a guide to setting it up using data volumes.

Describe the Enhancement

Provide a description of the enhancement request here.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones
  • Select milestone

Define Related Issue(s)

Consider the impact to the other METplus components.
This will be needed for other projects as well. Notably MET to recreate the existing nightly build functionality.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop and link the pull request to this issue.
    Pull request: feature <Issue Number> <Description>
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: testing Software testing issue priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: CI/CD Continuous integration and deployment issues labels Aug 17, 2020
@georgemccabe georgemccabe added this to To do in METplus-4.0.0-beta2 (12/8/20) via automation Oct 14, 2020
@georgemccabe georgemccabe added this to the METplus-4.0 milestone Oct 14, 2020
@georgemccabe georgemccabe added this to To do in METplus-4.0.0-beta3 (1/27/21) via automation Dec 2, 2020
@georgemccabe georgemccabe added this to To do in METplus-4.0.0-beta4 (3/2/21) via automation Jan 21, 2021
@georgemccabe georgemccabe self-assigned this Feb 11, 2021
@georgemccabe georgemccabe moved this from To do to In progress in METplus-4.0.0-beta4 (3/2/21) Feb 11, 2021
@georgemccabe georgemccabe linked a pull request Feb 18, 2021 that will close this issue
10 tasks
@georgemccabe
Copy link
Collaborator Author

This was completed with PR #810. A new issue with suggested improvements to this logic can be found in #812.

METplus-4.0.0-beta4 (3/2/21) automation moved this from In progress to Done Feb 18, 2021
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: CI/CD Continuous integration and deployment issues component: testing Software testing issue priority: medium Medium Priority reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants