Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle model, obtype, desc, and regrid dictionary the same for all wrappers that use them #755

Closed
21 tasks done
georgemccabe opened this issue Jan 11, 2021 · 0 comments · Fixed by #756
Closed
21 tasks done
Assignees
Labels
METplus: Configuration priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jan 11, 2021

Related to #748

Many MET tools have model, obtype, desc, and regrid in their config file. We would like to have these variables handled the same way for all wrappers.

Describe the Enhancement

Set these variables the same for all wrappers that use them. If unset, they should default to an empty string. If set, the environment variable set should include the variable name, i.e.

MODEL = FCST in METplus config file sets
model = FCST; in the MET config file or nothing if unset.

This will ensure that the default value in the default MET config file (share/met/config) will be used if it is not set in METplus so we don't have to keep the defaults in sync.

OBTYPE should be handled the same way.

DESCRIPTION should control desc for all configs unless a wrapper specific variable is used, i.e. GRID_STAT_DESCRIPTION.

All regrid dictionary variables should be supported and only set if they are set in the METplus config.

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.0.0-beta3

Funding Source

2791541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case configuration priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: NCAR/RAL NCAR Research Applications Laboratory labels Jan 11, 2021
@georgemccabe georgemccabe added this to the METplus-4.0 milestone Jan 11, 2021
@georgemccabe georgemccabe added this to To do in METplus-4.0.0-beta3 (1/27/21) via automation Jan 11, 2021
@georgemccabe georgemccabe self-assigned this Jan 11, 2021
@georgemccabe georgemccabe moved this from To do to In progress in METplus-4.0.0-beta3 (1/27/21) Jan 12, 2021
@georgemccabe georgemccabe linked a pull request Jan 12, 2021 that will close this issue
8 tasks
@georgemccabe georgemccabe moved this from In progress to Pull Request Review in METplus-4.0.0-beta3 (1/27/21) Jan 12, 2021
METplus-4.0.0-beta3 (1/27/21) automation moved this from Pull Request Review to Done Jan 13, 2021
@TaraJensen TaraJensen added the requestor: UK Met Office United Kingdom Met Office label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration priority: high High Priority requestor: NCAR/RAL NCAR Research Applications Laboratory requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants