Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls with both directory and file arguments still isn't quite right #61

Closed
nfischer opened this issue Mar 9, 2016 · 11 comments
Closed

ls with both directory and file arguments still isn't quite right #61

nfischer opened this issue Mar 9, 2016 · 11 comments
Assignees

Comments

@nfischer
Copy link
Collaborator

nfischer commented Mar 9, 2016

Just tried this after #60 got merged. The output still doesn't seem quite right. Here's the output I'm seeing from cash:

bash $ ./bin/cash.js
nate@lenovoyoga:~/programming/cash$ ls README.md bin/
README.mdalias.js    cash.js     cat.js      cd.js       clear.js
cp.js       echo.js     export.js   false.js    grep.js
head.js     kill.js     less.js     ls.js       mkdir.js
mv.js       parser.js   pwd.js      rm.js       sort.js
source.js   tail.js     touch.js    true.js     unalias.js
nate@lenovoyoga:~/programming/cash$ exit
bash $ ls README.md bin/
README.md

bin/:
alias.js  cp.js      head.js   mv.js      source.js
cash.js   echo.js    kill.js   parser.js  tail.js
cat.js    export.js  less.js   pwd.js     touch.js
cd.js     false.js   ls.js     rm.js      true.js
clear.js  grep.js    mkdir.js  sort.js    unalias.js

If multiple arguments are passed, directories should be displayed with the directory name above, followed by a colon (ex. bin/:). I couldn't find this issue if only directory arguments are used, only when both file and directory arguments are used.

@dthree
Copy link
Owner

dthree commented Mar 9, 2016

I didn't publish yet - did you pull down the changes in your local instance?

@nfischer
Copy link
Collaborator Author

nfischer commented Mar 9, 2016

I fetched the latest version of master, and ran npm update to make sure deps were up to date.

@dthree
Copy link
Owner

dthree commented Mar 9, 2016

Okay cool. I can check this out a bit later. It's probably a quick fix, no?

@nfischer
Copy link
Collaborator Author

nfischer commented Mar 9, 2016

Should be quick. I can probably fix it later this evening if you don't have time.

@dthree
Copy link
Owner

dthree commented Mar 9, 2016

That would be awesome if you could.

@nfischer
Copy link
Collaborator Author

nfischer commented Mar 9, 2016

👍

@i-am-steve-oh
Copy link
Collaborator

I actually know what the problem is 👎 .. @nfischer @dthree anyone fixed it yet?

@dthree
Copy link
Owner

dthree commented Mar 10, 2016

No...

@i-am-steve-oh
Copy link
Collaborator

Recursive doesn't work either. I'm fixing this stuff one after another.

@i-am-steve-oh i-am-steve-oh self-assigned this Mar 10, 2016
@dthree
Copy link
Owner

dthree commented Mar 10, 2016

K thanks!

@nfischer
Copy link
Collaborator Author

I actually have a fix written out for this. It also checks ls provides things in sorted order (gnu ls seems to do this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants