several build errors

[looterz]

Getting these when installing vantage,

utf-8-validate

$ if not defined npm_config_node_gyp (node "C:\Users\loote\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  bufferutil.cc
C:\projects\vantage-test\node_modules\nan\nan.h(263): error C2995: 'v8::Local<T> _NanEnsureLocal(v8::Local<T>)': function template has already been defined [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\projects\vantage-test\node_modules\nan\nan.h(256): note: see declaration of '_NanEnsureLocal'
C:\projects\vantage-test\node_modules\nan\nan.h(661): error C3083: 'smalloc': the symbol to the left of a '::' must be a type [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(661): error C2039: 'FreeCallback': is not a member of 'node' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_object_wrap.h(8): note: see declaration of 'node'
C:\projects\vantage-test\node_modules\nan\nan.h(661): error C2061: syntax error: identifier 'FreeCallback' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(665): error C2065: 'callback': undeclared identifier [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(665): error C2065: 'hint': undeclared identifier [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(672): error C2665: 'node::Buffer::New': none of the 4 overloads could convert all the argument types [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_buffer.h(43): note: could be 'v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate *,char *,size_t)'
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_buffer.h(31): note: or       'v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate *,v8::Local<v8::String>,node::encoding)'
  C:\projects\vantage-test\node_modules\nan\nan.h(672): note: while trying to match the argument list '(v8::Isolate *, const char *, uint32_t)'
C:\projects\vantage-test\node_modules\nan\nan.h(676): error C2440: 'return': cannot convert from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\projects\vantage-test\node_modules\nan\nan.h(676): note: No constructor could take the source type, or constructor overload resolution was ambiguous
C:\projects\vantage-test\node_modules\nan\nan.h(683): error C2039: 'Use': is not a member of 'node::Buffer' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_buffer.h(8): note: see declaration of 'node::Buffer'
C:\projects\vantage-test\node_modules\nan\nan.h(683): error C3861: 'Use': identifier not found [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
gyp ERR! build error

bufferutil

$ if not defined npm_config_node_gyp (node "C:\Users\loote\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  bufferutil.cc
C:\projects\vantage-test\node_modules\nan\nan.h(263): error C2995: 'v8::Local<T> _NanEnsureLocal(v8::Local<T>)': function template has already been defined [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\projects\vantage-test\node_modules\nan\nan.h(256): note: see declaration of '_NanEnsureLocal'
C:\projects\vantage-test\node_modules\nan\nan.h(661): error C3083: 'smalloc': the symbol to the left of a '::' must be a type [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(661): error C2039: 'FreeCallback': is not a member of 'node' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_object_wrap.h(8): note: see declaration of 'node'
C:\projects\vantage-test\node_modules\nan\nan.h(661): error C2061: syntax error: identifier 'FreeCallback' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(665): error C2065: 'callback': undeclared identifier [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(665): error C2065: 'hint': undeclared identifier [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
C:\projects\vantage-test\node_modules\nan\nan.h(672): error C2665: 'node::Buffer::New': none of the 4 overloads could convert all the argument types [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_buffer.h(43): note: could be 'v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate *,char *,size_t)'
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_buffer.h(31): note: or       'v8::MaybeLocal<v8::Object> node::Buffer::New(v8::Isolate *,v8::Local<v8::String>,node::encoding)'
  C:\projects\vantage-test\node_modules\nan\nan.h(672): note: while trying to match the argument list '(v8::Isolate *, const char *, uint32_t)'
C:\projects\vantage-test\node_modules\nan\nan.h(676): error C2440: 'return': cannot convert from 'v8::MaybeLocal<v8::Object>' to 'v8::Local<v8::Object>' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\projects\vantage-test\node_modules\nan\nan.h(676): note: No constructor could take the source type, or constructor overload resolution was ambiguous
C:\projects\vantage-test\node_modules\nan\nan.h(683): error C2039: 'Use': is not a member of 'node::Buffer' [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
  C:\Users\loote\.node-gyp\5.7.0\include\node\node_buffer.h(8): note: see declaration of 'node::Buffer'
C:\projects\vantage-test\node_modules\nan\nan.h(683): error C3861: 'Use': identifier not found [C:\projects\vantage-test\node_modules\bufferutil\build\bufferutil.vcxproj]
gyp ERR! build error

Info

Windows 10
node v5.7.0
npm 3.3.3
vantage @1.5.2

[dthree]

Looks like I need to do some dependency updates, maybe on Socket.IO.

Can you try it on Node v4.0.0 and see if you still get this error? Thanks.

[looterz]

Same errors on node v4.3.1

[dthree]

kk

[bsii]

@dthree — I'm caught up in a whirlwind of learning node.js.* — I've been away from programming a few years, and it turns out my beloved perl is that crazy uncle no one wants to talk about? And perl 6 still isn't out yet? The more things change...

Anyway, Vantage looked so rad that when I hit the build problems, I took it as a challenge to learn what would be involved in fixing it, which I did, hooray! I'm still learning my way around git, and since this diff'd fit in a tweet, I hope you don't mind a lazy patch? Hopefully next time I'll be able to submit things properly. ;-p

--- vantage-1.5.2/package.json  2016-02-15 22:05:19.000000000 -0800
+++ vantage-1.5.2/fixed/package.json    2016-03-03 17:25:01.000000000 -0800
@@ -55,4 +55,4 @@
     "native-promise-only": "0.8.0-a",
-    "socket.io": "1.3.6",
-    "socket.io-client": "1.3.6",
+    "socket.io": "1.3.7",
+    "socket.io-client": "1.3.7",
     "strip-ansi": "^3.0.0",

[dthree]

Hey thanks, and great on learning and diving in!

Did you test these patches and see that they did in fact fix the problem?