Fix use of basic auth in script URL

rundeck · Jun 18, 2012 · 1984747 · 1984747
1 parent a426c8b
commit 1984747
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/src/main/java/com/dtolabs/rundeck/core/common/impl/URLFileUpdater.java b/core/src/main/java/com/dtolabs/rundeck/core/common/impl/URLFileUpdater.java
@@ -241,14 +241,14 @@ private void updateHTTPUrl(final File destinationFile) throws FileUpdaterExcepti
                     url.getPort() > 0 ? url.getPort() : url.getDefaultPort(),
                     AuthScope.ANY_REALM, "BASIC");
                 cred = new UsernamePasswordCredentials(url.getUserInfo());
-                urlToUse = new URL(url.getHost(), url.getHost(), url.getPort(), url.getFile()).toExternalForm();
+                urlToUse = new URL(url.getProtocol(), url.getHost(), url.getPort(), url.getFile()).toExternalForm();
             } else if (null != username && null != password) {
                 doauth = true;
                 authscope = new AuthScope(url.getHost(),
                     url.getPort() > 0 ? url.getPort() : url.getDefaultPort(),
                     AuthScope.ANY_REALM, "BASIC");
                 cred = new UsernamePasswordCredentials(username + ":" + password);
-                urlToUse = new URL(url.getHost(), url.getHost(), url.getPort(), url.getFile()).toExternalForm();
+                urlToUse = new URL(url.getProtocol(), url.getHost(), url.getPort(), url.getFile()).toExternalForm();
             }
         } catch (MalformedURLException e) {
             throw new FileUpdaterException("Failed to configure base URL for authentication: " + e.getMessage(),